Commit 734246d 1 parent 132ae6d commit 734246d Copy full SHA for 734246d
File tree 4 files changed +16
-3
lines changed
helm/nvidia-dra-driver-gpu
4 files changed +16
-3
lines changed Original file line number Diff line number Diff line change @@ -27,6 +27,10 @@ ifeq ($(IMAGE_NAME),)
27
27
IMAGE_NAME := $(REGISTRY ) /$(DRIVER_NAME )
28
28
endif
29
29
30
+ # Note: this is sometimes a v-prefixed version string
31
+ # (in case of proper releases) or sometimes a commit hash
32
+ # (in case of regular CI builds) in which case VERSION
33
+ # is not v-prefixed.
30
34
IMAGE_VERSION := $(VERSION )
31
35
32
36
IMAGE_TAG ?= $(IMAGE_VERSION ) -$(DIST )
Original file line number Diff line number Diff line change @@ -15,10 +15,10 @@ type: application
15
15
# This is the chart version. This version number should be incremented each time you make changes
16
16
# to the chart and its templates, including the app version.
17
17
# Versions are expected to follow Semantic Versioning (https://semver.org/)
18
- version : v25 .3.0
18
+ version : 25 .3.0-rc.1
19
19
20
20
# This is the version number of the application being deployed. This version number should be
21
21
# incremented each time you make changes to the application. Versions are not expected to
22
22
# follow Semantic Versioning. They should reflect the version the application is using.
23
23
# It is recommended to use it with quotes.
24
- appVersion : " v25 .3.0"
24
+ appVersion : " 25 .3.0-rc.1 "
Original file line number Diff line number Diff line change @@ -19,10 +19,19 @@ set -o pipefail
19
19
# if arg1 is set, it will be used as the version number
20
20
if [ -z " $1 " ]; then
21
21
VERSION=$( awk -F= ' /^VERSION/ { print $2 }' versions.mk | tr -d ' [:space:]' )
22
+ # Remove any v prefix, if exists.
23
+ VERSION=" ${VERSION# v} "
22
24
else
23
25
VERSION=$1
24
26
fi
25
27
VERSION=${VERSION}
26
28
29
+
30
+ # Note(JP): the goal below is for VERSION to always be
31
+ # strictly semver-compliant (parseable with a semver
32
+ # parser). That enables best compatibility with the Helm
33
+ # ecosystem. For example, that means that no `v` prefix
34
+ # should be used here.
35
+
27
36
# Create release assets to be uploaded
28
37
helm package deployments/helm/nvidia-dra-driver-gpu/ --version $VERSION --app-version $VERSION
Original file line number Diff line number Diff line change @@ -18,7 +18,7 @@ MODULE := github.com/NVIDIA/$(DRIVER_NAME)
18
18
19
19
REGISTRY ?= nvcr.io/nvidia/cloud-native
20
20
21
- VERSION ?= v25.3.0
21
+ VERSION ?= v25.3.0-rc.1
22
22
23
23
# vVERSION represents the version with a guaranteed v-prefix
24
24
vVERSION := v$(VERSION:v%=% )
You can’t perform that action at this time.
0 commit comments