Mark geneformer test_pretrain_cli as slow #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstjohn
requested review from
jstjohn,
malcolmgreaves and
skothenhill-nv
as code owners
dorotat-nv
approved these changes
Jan 23, 2025
farhadrgh
approved these changes
Jan 23, 2025
jstjohn
approved these changes
Jan 23, 2025
This is one remaining outlier in our current test suite that takes a long time to run (~3 minutes by itself). https://app.codecov.io/gh/NVIDIA/bionemo-framework/tests/main With #634 we'll run these tests anyways during the merge queue step, but marking this as slow should speed up the coverage runs in PRs and post-merge Signed-off-by: Peter St. John <[email protected]>
Signed-off-by: Peter St. John <[email protected]>
pstjohn
force-pushed
the
pstjohn/mark-pretrain-cli-as-slow
branch
from
d16b10d to
2039967
Compare
polinabinder1
pushed a commit
that referenced
this pull request
Jan 28, 2025
This is one remaining outlier in our current test suite that takes a long time to run (~3 minutes by itself). https://app.codecov.io/gh/NVIDIA/bionemo-framework/tests/main With #634 we'll run these tests anyways during the merge queue step, but marking this as slow should speed up the coverage runs in PRs and post-merge --------- Signed-off-by: Peter St. John <[email protected]> Signed-off-by: Polina Binder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one remaining outlier in our current test suite that takes a long time to run (~3 minutes by itself). https://app.codecov.io/gh/NVIDIA/bionemo-framework/tests/main
With #634 we'll run these tests anyways during the merge queue step, but marking this as slow should speed up the coverage runs in PRs and post-merge