edit to approval workflow to avoid marking a failed action #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstjohn
requested review from
dorotat-nv,
jstjohn and
trvachov
as code owners
jomitchellnv
approved these changes
Jan 23, 2025
trvachov
approved these changes
Jan 23, 2025
Signed-off-by: Peter St. John <[email protected]>
Signed-off-by: Peter St. John <[email protected]>
pstjohn
force-pushed
the
pstjohn/approval-workflow-skip
branch
from
bf52187 to
5091404
Compare
pstjohn
commented
Jan 23, 2025
Signed-off-by: Peter St. John <[email protected]>
Signed-off-by: Peter St. John <[email protected]>
polinabinder1
pushed a commit
that referenced
this pull request
Jan 28, 2025
Rather than having a bunch of red 'X's on PRs that haven't gotten the required +2 review, we could have a conditional step that only runs when the required approvals are met. If we mark this as the required step in our branch rules it has the same effect, without cluttering our PR status with a bunch of failed status checks --------- Signed-off-by: Peter St. John <[email protected]> Signed-off-by: Polina Binder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than having a bunch of red 'X's on PRs that haven't gotten the required +2 review, we could have a conditional step that only runs when the required approvals are met. If we mark this as the required step in our branch rules it has the same effect, without cluttering our PR status with a bunch of failed status checks