Fix geneformer notebook tests by removing 10m_bnmo2 model #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter St. John <[email protected]>
pstjohn
added
the
INCLUDE_NOTEBOOKS_TESTS
pstjohn
requested review from
dorotat-nv,
jstjohn,
malcolmgreaves,
trvachov and
jwilber
as code owners
farhadrgh
approved these changes
Jan 23, 2025
dorotat-nv
approved these changes
Jan 23, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #649 +/- ##
=======================================
Coverage 86.79% 86.79%
=======================================
Files 118 118
Lines 7056 7056
=======================================
Hits 6124 6124
Misses 932 932 ☔ View full report in Codecov by Sentry. |
polinabinder1
pushed a commit
that referenced
this pull request
Jan 28, 2025
There seems to be an issue with the `geneformer_10m_bnmo2` checkpoint trying to load a no-longer-existent `BERTMLMLossWithReductionNoForward` layer. Commenting out this model from the celltype classification notebook until we can fix it. Signed-off-by: Peter St. John <[email protected]> Signed-off-by: Polina Binder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be an issue with the
geneformer_10m_bnmo2checkpoint trying to load a no-longer-existentBERTMLMLossWithReductionNoForwardlayer. Commenting out this model from the celltype classification notebook until we can fix it.