Simplify BIONEMO_HOME env var setting in ci scripts. #608
+16
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoobieieiee
requested review from
jstjohn,
malcolmgreaves and
skothenhill-nv
as code owners
trvachov
reviewed
Jan 15, 2025
| BIONEMO_HOME="${REPOSITORY_ROOT}" | ||
| echo "Setting \$BIONEMO_HOME to: $BIONEMO_HOME" | ||
| export BIONEMO_HOME=/workspace/bionemo2 | ||
| # # Ensure repository is clean |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simplify
BIONEMO_HOMEenv var setting to allow CI to run without error in the docker image.Otherwise,
ci/scripts/run_pytest.shwill try to look for a .git file which doesn't exist in the image.Type of changes
CI Pipeline Configuration
Configure CI behavior by applying the relevant labels:
Note
By default, the notebooks validation tests are skipped unless explicitly enabled.
Usage
ci/scripts/run_pytest.shPre-submit Checklist