JSON -> YAML for CLI #436
Merged
JSON -> YAML for CLI #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…issue in the case of duplicate filenames
…to hillst/async-checkpoint-war
…to hillst/async-checkpoint-war
skothenhill-nv
requested review from
jstjohn,
malcolmgreaves,
farhadrgh,
dorotat-nv and
pstjohn
as code owners
pstjohn
approved these changes
Nov 14, 2024
jstjohn
approved these changes
Nov 14, 2024
malcolmgreaves
approved these changes
Nov 14, 2024
dorotat-nv
requested changes
Nov 15, 2024
There was a problem hiding this comment.
thanks @skothenhill-nv ! I left some comments and spot a few places with the reference to json
…to hillst/yaml-parsing
|
/build-ci |
|
@skothenhill-nv , are there any unit tests that test those changes? Otherwise, spotted one typo in docs |
dorotat-nv
reviewed
Dec 2, 2024
Yes, sub-packages/bionemo-esm2/tests/bionemo/esm2/scripts/test_pydantic_train.py for esm2, and a similar test for geneformer. |
…to hillst/yaml-parsing
|
/build-ci |
dorotat-nv
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces JSON usage with YAML for the pydantic based CLI.
To do this, we had to add a few custom serializers for types not natively supported by YAML: