fix: remove text key with custom font value (solves stylesheet verify… #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and corbs console errors)
jwilber
requested review from
dorotat-nv,
jstjohn,
malcolmgreaves and
pstjohn
as code owners
tshimko-nv
approved these changes
Nov 8, 2024
pstjohn
approved these changes
Nov 8, 2024
|
/build-ci |
|
/build-ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a console issue that was showing up:
The issue was because we were referencing a custom font (
NVIDIA Sans) via thetext:field in the mkdocs.yml. Custom fonts should be handled in custom stylesheets (which they currently are) - referencing a font in the string will try to grab it from Google Fonts, hence the weird issue.I also formatted the text to use double-quotes.