-
Notifications
You must be signed in to change notification settings - Fork 7
Account for network errors during user folder retrieval #332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
690a711
throw error for network errors that arent 404s
jvigliotta 9c13666
debug
jvigliotta 3a0b7b0
throw error when non 404, return something so legacy persistence inte…
jvigliotta 13b10ff
return empty object to not trigger interceptor
jvigliotta 559b2e5
mimic missiong object return
jvigliotta ba43a8e
revert base persistence provider changes as they are not necessary
jvigliotta e1ea5c2
changes in base are actually need when creating missing
jvigliotta 89ac1c6
revert to see if there is a more logical way to do this
jvigliotta 0c16c55
debug
jvigliotta 497d8de
revert some things add back in error object to check in old persisten…
jvigliotta 4c7bd15
add check for error object in old persistence interceptor if so, dont…
jvigliotta 89929bb
only return error object for non 404 network errors
jvigliotta 97189df
remove debug
jvigliotta b2cbbf4
add retry on network errors for get
jvigliotta 3af93e1
revert retry logic
jvigliotta 32a4024
quick debug to test
jvigliotta f549c35
add openmct error notif
jvigliotta 1e20c9f
throw error from base persistence so mcws persistence provider can ha…
jvigliotta 2c600bd
add the getNamespace call to the try catch so any errors from that ar…
jvigliotta 4ed3c8c
use correct notification api
jvigliotta ee12839
remove debug
jvigliotta e3e7a0d
update error message
jvigliotta b082adb
remove clutter from notification message, correct wording
jvigliotta 3793e3f
;
jvigliotta 2b125b2
update comment
jvigliotta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.