Account for network errors during user folder retrieval

[jvigliotta]

closes #240

If there's an error getting an object that is NOT a 404, then we return an error object, similar to how we return a missing object for missing... objects (in our case for user folders a 404 means we create the root object:

openmct-mcws/src/persistence/BaseMCWSPersistenceProvider.js

Line 178 in 3f58be7

async createIfMissing(namespaceDefinition, userId) {

This addition of returning the error object, allows us to not try to save a missing object caused from a network error (no internet for example) in the case it's from an older persistence store that had folders on the backend, but no root object :

openmct-mcws/src/persistence/oldPersistenceFolderInterceptor.js

Line 52 in 3f58be7

openmct.objects.save(model);

Also added a retry loop. It will retry 3 times to get the object in 2, 4 and 8 second intervals at which point it will return the error object if there is still a network error.

[davetsay]

This looks good, but I just want to make sure you see this before approved.

I thought you said the unknown type check never happens, because the tree loading blocks the creation of the unknown object? If thats the case, maybe we shouldn't be coding for something that will never happen? If it does happen though, should we create an object Type to handle this, or maybe use another comparator such as object.unresolvedRequest===true (property name could need work), rather than a string check?

[jvigliotta]

This looks good, but I just want to make sure you see this before approved.

I thought you said the unknown type check never happens, because the tree loading blocks the creation of the unknown object? If thats the case, maybe we shouldn't be coding for something that will never happen? If it does happen though, should we create an object Type to handle this, or maybe use another comparator such as object.unresolvedRequest===true (property name could need work), rather than a string check?

The check happens, the object never makes it to the UI though. The check is what prevents the request from going out, so it's working in that regard. Let's chat about the check.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud