-
Notifications
You must be signed in to change notification settings - Fork 2
GEOPY-2604 #395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+42
−0
Merged
GEOPY-2604 #395
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
8abcd94
add validation to exclude plate-simulation and depth of investigation…
benk-mira cfb3143
handle if run_command and title are missing from options.
benk-mira 5b16630
Merge branch 'release/GA_4.8' into GEOPY-2604
benk-mira ac2260b
add docstring
benk-mira File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| # ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' | ||
| # Copyright (c) 2023-2026 Mira Geoscience Ltd. ' | ||
| # ' | ||
| # This file is part of simpeg-drivers package. ' | ||
| # ' | ||
| # simpeg-drivers is distributed under the terms and conditions of the MIT License ' | ||
| # (see LICENSE file at the root of this source code package). ' | ||
| # ' | ||
| # ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' | ||
|
|
||
| from unittest.mock import MagicMock | ||
|
|
||
| import pytest | ||
| from geoh5py import Workspace | ||
| from geoh5py.groups import SimPEGGroup | ||
| from pydantic import ValidationError | ||
|
|
||
| from simpeg_drivers.utils.tile_estimate import TileParameters | ||
|
|
||
|
|
||
| def test_simulation_validation_rejects_plate_simulation(tmp_path): | ||
| simulation = MagicMock(spec=SimPEGGroup) | ||
| simulation.options = { | ||
| "run_command": "simpeg_drivers.plate_simulation.driver", | ||
| "title": "Plate Simulation", | ||
| } | ||
|
|
||
| with Workspace.create(tmp_path / "test.geoh5") as geoh5: | ||
| with pytest.raises(ValidationError, match="not a valid target"): | ||
| TileParameters(geoh5=geoh5, simulation=simulation) | ||
|
benk-mira marked this conversation as resolved.
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.