Skip to content

GEOPY-2604#395

Merged
domfournier merged 4 commits into
release/GA_4.8from
GEOPY-2604
May 4, 2026
Merged

GEOPY-2604#395
domfournier merged 4 commits into
release/GA_4.8from
GEOPY-2604

Conversation

@benk-mira
Copy link
Copy Markdown
Contributor

@benk-mira benk-mira commented Apr 30, 2026

GEOPY-2604 - Validate incorrect SimPEGGroups in tile estimator and fail gracefully
… SimPEGGroups

Copilot AI review requested due to automatic review settings April 30, 2026 18:29
@benk-mira benk-mira changed the title add validation to exclude plate-simulation and depth of investigation… GEOPY-2604 Apr 30, 2026
@github-actions github-actions Bot changed the title GEOPY-2604 GEOPY-2604: add validation to exclude plate-simulation and depth of investigation… Apr 30, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds input validation to the tile estimation workflow to prevent unsupported SimPEGGroup targets (plate simulation and depth of investigation) from being used with the tile estimator.

Changes:

  • Added a Pydantic field validator on TileParameters.simulation to reject plate_simulation and depth_of_investigation run commands.
  • Added a new test asserting that plate simulation groups are rejected during TileParameters validation.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
simpeg_drivers/utils/tile_estimate.py Introduces validation logic to exclude unsupported simulation targets for tile estimation.
tests/utils_tile_estimate_test.py Adds a regression test for the new simulation-target validation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/utils_tile_estimate_test.py
Comment thread simpeg_drivers/utils/tile_estimate.py Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.17%. Comparing base (d1530a9) to head (ac2260b).
⚠️ Report is 5 commits behind head on release/GA_4.8.

Additional details and impacted files
@@                Coverage Diff                 @@
##           release/GA_4.8     #395      +/-   ##
==================================================
+ Coverage           90.14%   90.17%   +0.03%     
==================================================
  Files                 129      129              
  Lines                6486     6496      +10     
  Branches              821      822       +1     
==================================================
+ Hits                 5847     5858      +11     
  Misses                425      425              
+ Partials              214      213       -1     
Files with missing lines Coverage Δ
simpeg_drivers/utils/tile_estimate.py 87.59% <100.00%> (+0.97%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@benk-mira benk-mira changed the title GEOPY-2604: add validation to exclude plate-simulation and depth of investigation… GEOPY-2604 May 1, 2026
Comment thread simpeg_drivers/utils/tile_estimate.py
@domfournier domfournier merged commit 614d8f3 into release/GA_4.8 May 4, 2026
17 checks passed
@domfournier domfournier deleted the GEOPY-2604 branch May 4, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants