-
-
Notifications
You must be signed in to change notification settings - Fork 446
[7.0] Begin ForgeGradle 7.0's Release Candidate lifecycle #1001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: FG_7.0
Are you sure you want to change the base?
[7.0] Begin ForgeGradle 7.0's Release Candidate lifecycle #1001
Conversation
ccb4f0d to
09c6738
Compare
|
I'm unclear on the current state of FG7, so take this statement more generally: I'd rather the focus be on getting all the core functionality working reliably before locking in the API. Some past builds of the betas had breaking changes as it was later discovered that it couldn't be fixed without doing so. This helps avoid unintentional inflation of the major version for the sake of fixing something that requires minor breakages. |
|
Fixes can always be made without needing to break the API. But if we make a release candidate and start telling people to use it to help us test/migrate, then there's an API breakage that requires them to change something in their buildscript instead of just upgrading ForgeGradle, that can put a bad taste in people's mouths. That's why I am adament on an API freeze for the release candidate cycle. Please give me a clear list of the core functionalities I need to test over the next few days before starting release candidates. I'll start by making #988 a blocker for release candidates. |
Not always... that's my point. I'd prefer to delay the RC in favour of more fixes during beta first, just in case you get unlucky and end up needing to break API, as that way it wouldn't be unexpected. People can use fixed build numbers in their scripts during the beta period as usual. Yes that doesn't solve the MDK/buildscript update issue but isn't any worse than what we have now and would be a huge upgrade for those currently stuck on FG6 and wanting to help with real-world testing. Once the core functionality is reliably stable and tested, then start RCs.
JiJ becomes much less of a big need once MixinExtras is bundled in Forge and enabled automatically. Parchment is a nice to have but not a blocker for starting RCs imo. There's currently uncertainty if it'll be continued after Mojang distributes non-obf binaries |
|
Please see #996 for limitations on changing the Forge and Minecraft versions without re-syncing the project or explicitly running |
|
I've checked everything that is confirmed working so far. |
|
Gonna push back my preferred due date for the first release candidate by a week so I can give myself enough time to confirm compatibility in multi-loader setups. |
|
Needing to resync after changing versions is fine, that's already the norm for FG6. Presumably there's a check or error message if someone forgets? |
|
Yup! It is attached to compileJava. Though that reminds me to also attach it to the run tasks as well. |
85cbe14 to
9b0f120
Compare
jaredlll08/MultiLoader-Template#107 Link more multi-loader templates if you got them, please. |
9b0f120 to
bd5137e
Compare
|
Good evening. With the exception of Eclipse run configurations, I believe that ForgeGradle 7 is now in a state where it can be used in production. I've tested dropping it in as a replacement for ForgeGradle 6 in the template I linked earlier, along with bumping the Gradle wrapper to 9.2.0, and everything went smoothly. As for Eclipse, unfortunately, JavaExec tasks still cannot be hooked in with the debugger. This issue can be tracked in eclipse-buildship/buildship#1130. For now, what I can do is make a successor to the To clarify, I will not be recreating the I will leave it up to Lex as to whether the inclusion of For now, I will begin working on the full documentation, as well as the upgrade primer from ForgeGradle 6. |
|
The merging of this PR will mark the beginning of ForgeGradle 7's Release Candidate lifecycle. This crucially means a few things:
As an additional note, I'd like to begin stabilizing the other plugins as well. This includes JarJar Gradle, Multi-Release Java, and JVM Aggregate Testing.