Skip to content

Commit 09c6738

Browse files
committed
Hide ClosureOwner#getDelegateOwner
This member is only ever used internally. No need to expose it.
1 parent 0301930 commit 09c6738

File tree

5 files changed

+16
-18
lines changed

5 files changed

+16
-18
lines changed

src/main/java/net/minecraftforge/gradle/ClosureOwner.java

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -12,27 +12,16 @@
1212
/// without needing to create an object that does so. For example, the [net.minecraftforge.gradle.MinecraftDependency]
1313
/// implementation is not itself an [ExternalModuleDependency], but the [MinecraftDependency] closure owner provides an
1414
/// abstraction that delegates to both of those interfaces simultaneously.
15-
///
16-
/// @param <D> The type of the owner delegate to be used on top of the original owner
17-
public interface ClosureOwner<D> {
18-
/// Gets the owner delegate for this closure owner.
19-
///
20-
/// The owner delegate sits on top of the [Closure][groovy.lang.Closure]'s original
21-
/// {@linkplain groovy.lang.Closure#getOwner() owner}, and is used primarily on top of it when the closure owner is
22-
/// invoked. If a member can't be found in the owner delegate, the original owner is queried instead.
23-
///
24-
/// @return The owner delegate
25-
D getOwnerDelegate();
26-
15+
public interface ClosureOwner {
2716
/// A closure owner that delegates to [net.minecraftforge.gradle.MinecraftDependency] and
2817
/// [ExternalModuleDependency].
2918
///
3019
/// @see ClosureOwner
31-
interface MinecraftDependency extends ClosureOwner<net.minecraftforge.gradle.MinecraftDependency>, net.minecraftforge.gradle.MinecraftDependency, ExternalModuleDependency { }
20+
interface MinecraftDependency extends ClosureOwner, net.minecraftforge.gradle.MinecraftDependency, ExternalModuleDependency { }
3221

3322
/// A closure owner that delegates to [net.minecraftforge.gradle.MinecraftDependencyWithAccessTransformers] and
3423
/// [ExternalModuleDependency].
3524
///
3625
/// @see ClosureOwner
37-
interface MinecraftDependencyWithAccessTransformers extends ClosureOwner<net.minecraftforge.gradle.MinecraftDependencyWithAccessTransformers>, net.minecraftforge.gradle.MinecraftDependencyWithAccessTransformers, ExternalModuleDependency { }
26+
interface MinecraftDependencyWithAccessTransformers extends ClosureOwner, net.minecraftforge.gradle.MinecraftDependencyWithAccessTransformers, ExternalModuleDependency { }
3827
}

src/main/java/net/minecraftforge/gradle/MinecraftExtensionForProject.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
///
1919
/// @param <T> The type of closure owner used for [#dependency]
2020
/// @see MinecraftExtension
21-
public interface MinecraftExtensionForProject<T extends ClosureOwner<?>> extends MinecraftExtension {
21+
public interface MinecraftExtensionForProject<T extends ClosureOwner> extends MinecraftExtension {
2222
/// The collection of Slime Launcher options with which to create the launcher tasks.
2323
///
2424
/// @return The collection of run task options

src/main/java/net/minecraftforge/gradle/internal/ClosureOwnerInternal.java

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,16 @@
3232
import java.util.Map;
3333
import java.util.Set;
3434

35-
interface ClosureOwnerInternal<D> extends ClosureOwner<D> {
35+
interface ClosureOwnerInternal<D> extends ClosureOwner {
36+
/// Gets the owner delegate for this closure owner.
37+
///
38+
/// The owner delegate sits on top of the [Closure][groovy.lang.Closure]'s original
39+
/// {@linkplain groovy.lang.Closure#getOwner() owner}, and is used primarily on top of it when the closure owner is
40+
/// invoked. If a member can't be found in the owner delegate, the original owner is queried instead.
41+
///
42+
/// @return The owner delegate
43+
D getOwnerDelegate();
44+
3645
private static RuntimeException stub() {
3746
return new UnsupportedOperationException();
3847
}

src/main/java/net/minecraftforge/gradle/internal/MinecraftExtensionImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ private void finish(Settings settings) {
143143
}
144144
}
145145

146-
static abstract class ForProjectImpl<T extends ClosureOwner<?> & MinecraftDependency & ExternalModuleDependency> extends MinecraftExtensionImpl implements MinecraftExtensionInternal.ForProject<T> {
146+
static abstract class ForProjectImpl<T extends ClosureOwner & MinecraftDependency & ExternalModuleDependency> extends MinecraftExtensionImpl implements MinecraftExtensionInternal.ForProject<T> {
147147
// Slime Launcher
148148
private final NamedDomainObjectContainer<SlimeLauncherOptionsImpl> runs;
149149

src/main/java/net/minecraftforge/gradle/internal/MinecraftExtensionInternal.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public Attribute<String> getMappingsVersion() {
4949
}
5050
}
5151

52-
interface ForProject<T extends ClosureOwner<?>> extends MinecraftExtensionForProject<T>, MinecraftExtensionInternal, HasPublicType {
52+
interface ForProject<T extends ClosureOwner> extends MinecraftExtensionForProject<T>, MinecraftExtensionInternal, HasPublicType {
5353
@Override
5454
default TypeOf<?> getPublicType() {
5555
return new TypeOf<MinecraftExtensionForProject<ClosureOwner.MinecraftDependency>>() { };

0 commit comments

Comments
 (0)