Skip to content

Bump up proof systems to include Rust 1.82 support #16791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dannywillems
Copy link
Member

@dannywillems dannywillems commented Mar 27, 2025

Built on top of #16782

It includes the following changes from proof-systems:

Creating this step as an intermediary PR as some dependencies have been updated and implies that cargo vendor must be run.

The reviewer is encouraged to run the commands locally from the base branch, and verify that no other significant changes that would impact Mina are included.
In a future PR, Rust 1.82 will be used in Mina.

Counterparty in kimchi-stubs-vendors: MinaProtocol/kimchi-stubs-vendors#5

@dannywillems dannywillems requested a review from a team as a code owner March 27, 2025 15:55
@dannywillems
Copy link
Member Author

!ci-build-me

@dannywillems
Copy link
Member Author

!ci-build-me

1 similar comment
@dannywillems
Copy link
Member Author

!ci-build-me

@dannywillems
Copy link
Member Author

!ci-build-me

@dannywillems dannywillems changed the base branch from dw/bumping-up-proof-systems-deps to compatible March 27, 2025 17:13
@dannywillems
Copy link
Member Author

Changed targeted branch to compatible as #16782 has been merged.

@dannywillems
Copy link
Member Author

dannywillems commented Mar 27, 2025

For the reviewers.
Here the commands I run. Be sure to clean kimchi-stubs-vendors first to not have any other changes:

git checkout compatible
git checkout 85d1991fb1ca0c97f01a065928c07a70e3fd5ab7 # first commit of the PR bumping up proof-systems
git submodule update --init --recursive --force
cd src/lib/crypto/kimchi_bindings/stubs
cargo vendor kimchi-stubs-vendors
cd kimchi-stubs-vendors
git status

The output should only contain syn, serde_with, serde, serde_derive and serde_with_macros, which are exactly the changes of this commit.

@dannywillems
Copy link
Member Author

Merged compatible to get the changes from #16780 to avoid future conflicts in #16794 as I am going to remove the lines related to Rust 1.79.

@dannywillems
Copy link
Member Author

!ci-build-me

@dannywillems
Copy link
Member Author

I'm adding the changelog.

@dannywillems
Copy link
Member Author

!ci-build-me

@dannywillems
Copy link
Member Author

Solving conflicts now.

@dannywillems
Copy link
Member Author

!ci-build-me

@dannywillems
Copy link
Member Author

!ci-build-me

@dannywillems dannywillems merged commit 50f8994 into compatible Mar 31, 2025
46 checks passed
@dannywillems dannywillems deleted the dw/bump-up-proof-systems-to-include-rust-82-support branch March 31, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants