Skip to content

WASM Memory boosting mode with lazy cache #16722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 28, 2025
Merged

WASM Memory boosting mode with lazy cache #16722

merged 4 commits into from
May 28, 2025
+150 −57

Conversation

querolita
Copy link
Member

@querolita querolita commented Mar 13, 2025 •
edited
Loading

Explain your changes:

  • Updated bindings (wasm, stubs, js) to include the lazy_mode flag at setup and prover index creation.

Explain how you tested your changes:

  • There's a playground where we measured the memory impact of this flag, showing some savings at setup time.

Closes #2006 (mina side o1-labs/o1js#2073)

@querolita querolita closed this Mar 19, 2025
@querolita querolita reopened this Mar 19, 2025
@querolita querolita changed the base branch from develop to compatible March 27, 2025 16:52
@querolita
Copy link
Member Author

querolita commented Mar 27, 2025 •
edited
Loading

Don't merge before #16794 and #16791 are merged

@querolita querolita force-pushed the project/wasm-mode branch from aea59f6 to f283c95 Compare April 2, 2025 11:29
@dannywillems
Copy link
Member

!ci-build-me

@querolita querolita marked this pull request as ready for review April 17, 2025 11:17
@querolita querolita requested a review from a team as a code owner April 17, 2025 11:17
@glyh
Copy link
Member

glyh commented May 1, 2025

I think @amc-ie wants change logs to be one-liners

@querolita querolita mentioned this pull request May 21, 2025
Closed
@dannywillems
Copy link
Member

dannywillems commented May 22, 2025 •
edited
Loading

Can you clean the history please? Bump up of dependencies should be in a single commit, one per dependencies. In addition to that, it would be nice to remove merge commits.
We need to backport the changes in saffron, and we will need to cherry-pick one-by-one. At the moment, we cannot move on saffron before the counterpart on proof-systems has been merged.

@querolita querolita force-pushed the project/wasm-mode branch 3 times, most recently from bfa85c9 to 06c6731 Compare May 22, 2025 14:10
dannywillems
dannywillems reviewed May 22, 2025
View reviewed changes
dannywillems
dannywillems approved these changes May 27, 2025
View reviewed changes
Copy link
Member

@dannywillems dannywillems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would simplify the history by removing the git merge commit and rebasing on the latest compatible.

@querolita querolita force-pushed the project/wasm-mode branch from 66fe094 to b4ca393 Compare May 28, 2025 09:21
@querolita
Copy link
Member Author

!ci-build-me

@querolita querolita merged commit 9c42b40 into compatible May 28, 2025
50 checks passed
@querolita querolita deleted the project/wasm-mode branch May 28, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannywillems dannywillems dannywillems approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@querolita @dannywillems @glyh