Skip to content

fix(ramp): Correct ramp v2 order detail's crypto amount formatting #27469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
imyugioh wants to merge 2 commits into
base: main
Choose a base branch
from
+60 −2
Open

fix(ramp): Correct ramp v2 order detail's crypto amount formatting #27469

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ceb9eb
fix: ramp v2 order detail's crypto amount formatting
imyugioh Mar 13, 2026
188a754
fix: case amount is null
imyugioh Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions app/components/UI/Ramp/Views/OrderDetails/OrderContent.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,38 @@ describe('OrderContent', () => {
).toBeOnTheScreen();
});

it('truncates long crypto amounts to 5 decimal places', () => {
const longDecimalOrder: RampsOrder = {
...mockOrder,
cryptoAmount: 0.01588973776561068,
};
renderOrder(longDecimalOrder);
const tokenAmount = screen.getByTestId('ramps-order-details-token-amount');
expect(tokenAmount.props.children).not.toContain('0.01588973776561068');
expect(tokenAmount).toHaveTextContent('0.01589 ETH');
});

it('uses subscript notation for very small crypto amounts', () => {
const tinyAmountOrder: RampsOrder = {
...mockOrder,
cryptoAmount: 0.00000614,
};
renderOrder(tinyAmountOrder);
const tokenAmount = screen.getByTestId('ramps-order-details-token-amount');
// 0.00000614 has 5 leading zeros → "0.0₅614"
expect(tokenAmount).toHaveTextContent('0.0₅614 ETH');
});

it('shows "..." when cryptoAmount is missing', () => {
const noAmountOrder: RampsOrder = {
...mockOrder,
cryptoAmount: undefined as unknown as number,
};
renderOrder(noAmountOrder);
const tokenAmount = screen.getByTestId('ramps-order-details-token-amount');
expect(tokenAmount).toHaveTextContent('... ETH');
});

it('does not render info row when statusDescription is absent', () => {
const orderWithoutDescription: RampsOrder = {
...mockOrder,
Expand Down
20 changes: 18 additions & 2 deletions app/components/UI/Ramp/Views/OrderDetails/OrderContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,11 @@ import BadgeWrapper, {
BadgePosition,
} from '../../../../../component-library/components/Badges/BadgeWrapper';
import { AvatarSize } from '../../../../../component-library/components/Avatars/Avatar';
import { strings } from '../../../../../../locales/i18n';
import I18n, { strings } from '../../../../../../locales/i18n';
import { toDateFormat } from '../../../../../util/date';
import { renderFiat } from '../../../../../util/number';
import { formatSubscriptNotation } from '../../../../../util/number/subscriptNotation';
import { formatWithThreshold } from '../../../../../util/assets';
import { getNetworkImageSource } from '../../../../../util/networks';
import Logger from '../../../../../util/Logger';
import Button, {
Expand Down Expand Up @@ -318,7 +320,21 @@ const OrderContent: React.FC<OrderContentProps> = ({
fontWeight={FontWeight.Bold}
twClassName="mt-6 text-center"
>
{order.cryptoAmount} {cryptoSymbol}
{order.cryptoAmount
? (formatSubscriptNotation(
parseFloat(String(order.cryptoAmount)),
) ??
formatWithThreshold(
parseFloat(String(order.cryptoAmount)),
0.00001,
I18n.locale,
{
minimumFractionDigits: 0,
maximumFractionDigits: 5,
},
))
: '...'}{' '}
{cryptoSymbol}
</Text>
</Box>

Expand Down
Loading