fix(ramp): Correct ramp v2 order detail's crypto amount formatting#27469
Open
imyugioh wants to merge 2 commits intoMetaMask:mainfrom
Open
fix(ramp): Correct ramp v2 order detail's crypto amount formatting#27469imyugioh wants to merge 2 commits intoMetaMask:mainfrom
imyugioh wants to merge 2 commits intoMetaMask:mainfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Fixes excessive decimal places on the Order Details screen for ramp purchases. When buying crypto (e.g. ETH via Mercuryo), the
cryptoAmountwas displayed raw with up to 17 decimal digits (0.01588973776561068), breaking the layout.Now the amount is formatted consistently with the home screen:
formatWithThreshold(e.g.0.01589 ETH)formatSubscriptNotation(e.g.0.0₅4567 BTC)...Changelog
CHANGELOG entry: Fixed Order Details screen displaying excessive decimal places for crypto amounts after ramp purchases.
Related issues
Refs:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk UI-only change that adjusts number formatting on the ramp Order Details screen and adds unit tests for edge cases (tiny, long-decimal, missing, and zero amounts).
Overview
Fixes ramp v2 Order Details to format
cryptoAmountinstead of rendering the raw number, preventing long decimals from breaking layout.Amounts now prefer
formatSubscriptNotationfor very small values, otherwise useformatWithThresholdwith a 5-decimal cap and currentI18n.locale; missing amounts render as.... Adds tests covering long decimals, subscript formatting, missing values, and zero.Written by Cursor Bugbot for commit 188a754. This will update automatically on new commits. Configure here.