Skip to content

refactor: Reverted selected state for explore tab icon cp-7.69.1 cp-7.70.0 #27459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brianacnguyen merged 1 commit into from
Mar 16, 2026
+1 −1
Merged

refactor: Reverted selected state for explore tab icon cp-7.69.1 cp-7.70.0 #27459

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/component-library/components/Navigation/TabBar/TabBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ import { useAccountMenuEnabled } from '../../../../selectors/featureFlagControll
const FILLED_ICONS: Partial<Record<TabBarIconKey, IconName>> = {
[TabBarIconKey.Wallet]: IconName.HomeFilled,
[TabBarIconKey.Activity]: IconName.ClockFilled,
[TabBarIconKey.Trending]: IconName.SearchFilled,
[TabBarIconKey.Trending]: IconName.Search,
Copy link

@cursor cursor bot Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant FILLED_ICONS entry duplicates base icon value

Low Severity

The FILLED_ICONS entry for TabBarIconKey.Trending now maps to IconName.Search, which is identical to the base icon in ICON_BY_TAB_BAR_ICON_KEY. The fallback ?? baseIcon on line 62 already handles this case, making this entry functionally redundant. Keeping it in a map named FILLED_ICONS is also semantically misleading since it no longer points to a filled variant — a future developer may wonder why an outline icon appears in the "filled" map.

Fix in Cursor Fix in Web

[TabBarIconKey.Rewards]: IconName.MetamaskFoxFilled,
};

Expand Down
Loading