refactor: Reverted selected state for explore tab icon cp-7.69.1 cp-7.70.0

[brianacnguyen]

Description

Updates the Explore (Trending) tab icon in the main tab bar from the filled variant to the outline variant.

Changelog

CHANGELOG entry: Updated Explore tab icon in the main tab bar to use the outline style.

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/DSYS-578

Manual testing steps

Feature: Explore tab icon in tab bar

  Scenario: Explore tab shows outline search icon
    Given the app is open and the user is on any main tab

    When the user views the tab bar
    Then the Explore (Trending) tab shows the outline search icon (not the filled variant)
    And the icon is visible and correctly aligned with other tab icons

Screenshots/Recordings

Before

After

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2026-03-12.at.16.21.02.mov

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Low Risk
Low risk visual-only change that swaps the selected-state icon for the Explore/Trending tab; no navigation, analytics, or data flows are affected.

Overview
Updates the TabBar selected-state icon mapping for the Explore/Trending tab to use the outline IconName.Search instead of the filled IconName.SearchFilled, reverting its “active” appearance to match the outline style.

^{Written by Cursor Bugbot for commit 829d018. This will update automatically on new commits. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeWalletPlatform
• Selected Performance tags: None (no tests recommended)
• Risk Level: low
• AI Confidence: 70%

click to see 🤖 AI reasoning details

E2E Test Selection:
The only change is a visual update in TabBar.tsx: replacing the Trending tab filled icon from SearchFilled to Search. There are no logic, navigation, state management, or controller changes—only an icon mapping update.

However, TabBar is a global navigation component used across the app (Wallet, Activity, Trending, Rewards). The most directly impacted area is the Trending tab, which is covered under SmokeWalletPlatform (including Trending discovery tab and its integration with navigation). Running this suite ensures that tab navigation—especially to Trending—still works correctly and that no unintended UI regressions affect core wallet platform flows.

No controller, Engine, network, account, trade, or confirmation logic was modified, so broader domain-specific tags (e.g., SmokeAccounts, SmokeConfirmations, SmokeTrade, SmokeNetworkExpansion) are not required for adequate risk coverage.

Given this is a UI-only icon change with no behavioral modification, risk is low and a focused platform-level smoke suite is sufficient.

Performance Test Selection:
The change only updates an icon reference in the TabBar component and does not affect rendering complexity, list performance, startup flow, or data loading. There is no impact on performance-sensitive paths such as account lists, onboarding, swaps, predictions, perps, or app launch. Therefore, no performance tests are required.

View GitHub Actions results

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

[cursor]

Redundant FILLED_ICONS entry duplicates base icon value

Low Severity

The FILLED_ICONS entry for TabBarIconKey.Trending now maps to IconName.Search, which is identical to the base icon in ICON_BY_TAB_BAR_ICON_KEY. The fallback ?? baseIcon on line 62 already handles this case, making this entry functionally redundant. Keeping it in a map named FILLED_ICONS is also semantically misleading since it no longer points to a filled variant — a future developer may wonder why an outline icon appears in the "filled" map.

 

[github-actions]

✅ E2E Fixture Validation — Schema is up to date
16 value mismatches detected (expected — fixture represents an existing user).
View details

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud