Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -187,8 +187,8 @@ android {
applicationId "io.metamask"
minSdkVersion rootProject.ext.minSdkVersion
targetSdkVersion rootProject.ext.targetSdkVersion
versionName "7.70.0"
versionCode 3607
versionName "7.70.13"
versionCode 4016
testBuildType System.getProperty('testBuildType', 'debug')
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
manifestPlaceholders.MM_BRANCH_KEY_TEST = "$System.env.MM_BRANCH_KEY_TEST"
Expand Down
9 changes: 9 additions & 0 deletions app/components/Views/Wallet/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@
import DeFiPositionsList from '../../UI/DeFiPositions/DeFiPositionsList';
import AssetDetailsActions from '../AssetDetails/AssetDetailsActions';
import AppConstants from '../../../core/AppConstants';
import { OTA_VERSION } from '../../../constants/ota';
///: BEGIN:ONLY_INCLUDE_IF(keyring-snaps)
import { useSendNonEvmAsset } from '../../hooks/useSendNonEvmAsset';
///: END:ONLY_INCLUDE_IF
Expand Down Expand Up @@ -245,6 +246,11 @@
headerAccountPickerStyle: {
marginRight: 16,
},
otaText: {
marginTop: 4,
fontSize: 10,
opacity: 0.7,
},
});

interface WalletProps {
Expand Down Expand Up @@ -1482,6 +1488,9 @@
/>
) : null}
<NetworkConnectionBanner />
<CustomText color={TextColor.Muted} style={styles.otaText}>

Check warning on line 1491 in app/components/Views/Wallet/index.tsx

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

'CustomText' is deprecated.

See more on https://sonarcloud.io/project/issues?id=metamask-mobile&issues=AZzjgi24Sua2IGoDarVA&open=AZzjgi24Sua2IGoDarVA&pullRequest=27450
OTA {OTA_VERSION}
</CustomText>

Check warning on line 1493 in app/components/Views/Wallet/index.tsx

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

'CustomText' is deprecated.

See more on https://sonarcloud.io/project/issues?id=metamask-mobile&issues=AZzjgi24Sua2IGoDarVB&open=AZzjgi24Sua2IGoDarVB&pullRequest=27450
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug OTA version text shown to all users

High Severity

The OTA_VERSION text is rendered unconditionally on the main wallet screen, visible to all production users. Unlike the existing usage in Settings/AppInformation/index.js where OTA details are gated behind isOTAUpdatesEnabled and __DEV__ checks, this new CustomText element has no conditional rendering. Every user will see "OTA v7.70.13" on their primary wallet view. This appears to be debug/testing code that was not removed before the PR.

Additional Locations (1)
Fix in Cursor Fix in Web

</View>
<>
<AccountGroupBalance />
Expand Down
2 changes: 1 addition & 1 deletion app/constants/ota.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import otaConfig from '../../ota.config.js';
* Reset to v0 when releasing a new native build
* We keep this OTA_VERSION here to because changes in ota.config.js will affect the fingerprint and break the workflow in Github Actions
*/
export const OTA_VERSION: string = 'v7.65.1';
export const OTA_VERSION: string = 'v7.70.13';
export const RUNTIME_VERSION = otaConfig.RUNTIME_VERSION;
export const PROJECT_ID = otaConfig.PROJECT_ID;
export const UPDATE_URL = otaConfig.UPDATE_URL;
8 changes: 4 additions & 4 deletions bitrise.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3531,16 +3531,16 @@ app:
PROJECT_LOCATION_IOS: ios
- opts:
is_expand: false
VERSION_NAME: 7.70.0
VERSION_NAME: 7.70.13
- opts:
is_expand: false
VERSION_NUMBER: 3911
VERSION_NUMBER: 4016
- opts:
is_expand: false
FLASK_VERSION_NAME: 7.70.0
FLASK_VERSION_NAME: 7.70.13
- opts:
is_expand: false
FLASK_VERSION_NUMBER: 3911
FLASK_VERSION_NUMBER: 4016
- opts:
is_expand: false
ANDROID_APK_LINK: ''
Expand Down
24 changes: 12 additions & 12 deletions ios/MetaMask.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -1281,7 +1281,7 @@
CODE_SIGN_IDENTITY = "Apple Development";
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
CODE_SIGN_STYLE = Manual;
CURRENT_PROJECT_VERSION = 3911;
CURRENT_PROJECT_VERSION = 4016;
DEAD_CODE_STRIPPING = YES;
DEBUG_INFORMATION_FORMAT = dwarf;
DEVELOPMENT_TEAM = 48XVW22RCG;
Expand Down Expand Up @@ -1319,7 +1319,7 @@
"${inherited}",
);
LLVM_LTO = YES;
MARKETING_VERSION = 7.70.0;
MARKETING_VERSION = 7.70.13;
ONLY_ACTIVE_ARCH = YES;
OTHER_CFLAGS = "$(inherited)";
OTHER_LDFLAGS = (
Expand Down Expand Up @@ -1350,7 +1350,7 @@
CODE_SIGN_ENTITLEMENTS = MetaMask/MetaMask.entitlements;
CODE_SIGN_IDENTITY = "iPhone Distribution";
CODE_SIGN_STYLE = Manual;
CURRENT_PROJECT_VERSION = 3911;
CURRENT_PROJECT_VERSION = 4016;
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
DEVELOPMENT_TEAM = 48XVW22RCG;
"DEVELOPMENT_TEAM[sdk=iphoneos*]" = 48XVW22RCG;
Expand Down Expand Up @@ -1385,7 +1385,7 @@
"${inherited}",
);
LLVM_LTO = YES;
MARKETING_VERSION = 7.70.0;
MARKETING_VERSION = 7.70.13;
ONLY_ACTIVE_ARCH = NO;
OTHER_CFLAGS = "$(inherited)";
OTHER_LDFLAGS = (
Expand Down Expand Up @@ -1416,7 +1416,7 @@
CODE_SIGN_IDENTITY = "Apple Development";
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
CODE_SIGN_STYLE = Manual;
CURRENT_PROJECT_VERSION = 3911;
CURRENT_PROJECT_VERSION = 4016;
DEAD_CODE_STRIPPING = YES;
DEBUG_INFORMATION_FORMAT = dwarf;
DEVELOPMENT_TEAM = 48XVW22RCG;
Expand Down Expand Up @@ -1454,7 +1454,7 @@
"\"$(SRCROOT)/MetaMask/System/Library/Frameworks\"",
);
LLVM_LTO = YES;
MARKETING_VERSION = 7.70.0;
MARKETING_VERSION = 7.70.13;
ONLY_ACTIVE_ARCH = YES;
OTHER_CFLAGS = "$(inherited)";
OTHER_LDFLAGS = (
Expand Down Expand Up @@ -1483,7 +1483,7 @@
CODE_SIGN_ENTITLEMENTS = MetaMask/MetaMask.entitlements;
CODE_SIGN_IDENTITY = "iPhone Distribution";
CODE_SIGN_STYLE = Manual;
CURRENT_PROJECT_VERSION = 3911;
CURRENT_PROJECT_VERSION = 4016;
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
DEVELOPMENT_TEAM = 48XVW22RCG;
"DEVELOPMENT_TEAM[sdk=iphoneos*]" = 48XVW22RCG;
Expand Down Expand Up @@ -1518,7 +1518,7 @@
"\"$(SRCROOT)/MetaMask/System/Library/Frameworks\"",
);
LLVM_LTO = YES;
MARKETING_VERSION = 7.70.0;
MARKETING_VERSION = 7.70.13;
ONLY_ACTIVE_ARCH = NO;
OTHER_CFLAGS = "$(inherited)";
OTHER_LDFLAGS = (
Expand Down Expand Up @@ -1646,7 +1646,7 @@
CODE_SIGN_IDENTITY = "Apple Development";
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
CODE_SIGN_STYLE = Manual;
CURRENT_PROJECT_VERSION = 3911;
CURRENT_PROJECT_VERSION = 4016;
DEAD_CODE_STRIPPING = YES;
DEBUG_INFORMATION_FORMAT = dwarf;
DEVELOPMENT_TEAM = 48XVW22RCG;
Expand Down Expand Up @@ -1684,7 +1684,7 @@
"\"$(SRCROOT)/MetaMask/System/Library/Frameworks\"",
);
LLVM_LTO = YES;
MARKETING_VERSION = 7.70.0;
MARKETING_VERSION = 7.70.13;
ONLY_ACTIVE_ARCH = YES;
OTHER_CFLAGS = (
"$(inherited)",
Expand Down Expand Up @@ -1716,7 +1716,7 @@
CODE_SIGN_ENTITLEMENTS = MetaMask/MetaMask.entitlements;
CODE_SIGN_IDENTITY = "iPhone Distribution";
CODE_SIGN_STYLE = Manual;
CURRENT_PROJECT_VERSION = 3911;
CURRENT_PROJECT_VERSION = 4016;
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
DEVELOPMENT_TEAM = 48XVW22RCG;
"DEVELOPMENT_TEAM[sdk=iphoneos*]" = 48XVW22RCG;
Expand Down Expand Up @@ -1751,7 +1751,7 @@
"\"$(SRCROOT)/MetaMask/System/Library/Frameworks\"",
);
LLVM_LTO = YES;
MARKETING_VERSION = 7.70.0;
MARKETING_VERSION = 7.70.13;
ONLY_ACTIVE_ARCH = NO;
OTHER_CFLAGS = (
"$(inherited)",
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "metamask",
"version": "7.70.0",
"version": "7.70.13",
"private": true,
"scripts": {
"install:foundryup": "yarn mm-foundryup",
Expand Down
Loading