Skip to content

Ota/7.70.13#27450

Open
weitingsun wants to merge 3 commits intomainfrom
ota/7.70.13
Open

Ota/7.70.13#27450
weitingsun wants to merge 3 commits intomainfrom
ota/7.70.13

Conversation

@weitingsun
Copy link
Contributor

@weitingsun weitingsun commented Mar 12, 2026

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Primarily a version/CI bump plus a small UI label change; low risk aside from potential build/release pipeline mismatches if version numbers are inconsistent across platforms.

Overview
Updates the app release version to 7.70.13 (build 4016) across Android (build.gradle), iOS project settings, package.json, and Bitrise CI environment variables.

Adds a small, muted OTA {OTA_VERSION} label to the Wallet banner area and updates OTA_VERSION to v7.70.13 to track the current OTA update version.

Written by Cursor Bugbot for commit 315da2c. This will update automatically on new commits. Configure here.

@weitingsun weitingsun requested a review from a team as a code owner March 12, 2026 18:58
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Mar 12, 2026
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

<NetworkConnectionBanner />
<CustomText color={TextColor.Muted} style={styles.otaText}>
OTA {OTA_VERSION}
</CustomText>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug OTA version text shown to all users

High Severity

The OTA_VERSION text is rendered unconditionally on the main wallet screen, visible to all production users. Unlike the existing usage in Settings/AppInformation/index.js where OTA details are gated behind isOTAUpdatesEnabled and __DEV__ checks, this new CustomText element has no conditional rendering. Every user will see "OTA v7.70.13" on their primary wallet view. This appears to be debug/testing code that was not removed before the PR.

Additional Locations (1)
Fix in Cursor Fix in Web

@github-actions
Copy link
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeWalletPlatform
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 75%
click to see 🤖 AI reasoning details

E2E Test Selection:
The PR introduces a small UI change to the main Wallet screen (app/components/Views/Wallet/index.tsx) by displaying a static "OTA {OTA_VERSION}" text under the NetworkConnectionBanner. It also updates the OTA_VERSION constant and likely version/build metadata (package.json, native project files, CI config). There are no changes to controllers, Engine, state management, navigation structure, or business logic.

However, the Wallet screen is a central hub used by many flows and is directly covered by SmokeWalletPlatform (Trending tab, transaction history, multi-SRP architecture, wallet lifecycle events). Since the layout of the Wallet header area is modified, there is a moderate risk of unintended UI regressions (e.g., layout shifts, element overlap, visibility issues) that could affect wallet home interactions.

No changes impact confirmations, trade logic, network management, identity sync, snaps, or multi-chain APIs. Therefore, additional tags (e.g., SmokeTrade, SmokeConfirmations, SmokeNetworkAbstractions, etc.) are not required.

Selecting SmokeWalletPlatform provides sufficient coverage of the modified screen while minimizing unnecessary test execution.

Performance Test Selection:
The change only adds a small static text element to the Wallet header and updates a version constant. There are no changes to rendering-heavy components, lists, state management, controllers, or startup logic. This is extremely unlikely to impact app launch time, asset loading, or UI performance, so no performance tests are required.

View GitHub Actions results

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@github-actions
Copy link
Contributor

E2E Fixture Validation — Schema is up to date
16 value mismatches detected (expected — fixture represents an existing user).
View details

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size-S team-mobile-platform Mobile Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants