Drop Log Collection Backend #23647
Merged
Drop Log Collection Backend #23647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fryguy
requested review from
agrare,
bdunne,
jrafanie and
kbrock
as code owners
Fryguy
force-pushed
the
drop_log_collection
branch
3 times, most recently
from
0789366 to
15ba91c
Compare
Fryguy
force-pushed
the
drop_log_collection
branch
from
15ba91c to
c0ffe2e
Compare
In containerized deployments we can't support log collection, because we can't mount the log depot. In appliance deployments, we're trying to get away from the application UI having anything to do with the system it's running on to avoid the need to elevate permissions. As such, this commit removes log collection from backend. The UI will be done separately. Instead, on appliances, users can manually mount an NFS server (or really any server type - even more than our UI supports), and then use the /var/www/miq/vmdb/tools/collect_logs tool. If the user needs scheduling, they can schedule a cron on the appliance to run the tool.
Fryguy
force-pushed
the
drop_log_collection
branch
from
c0ffe2e to
4f2df52
Compare
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Nov 4, 2025
From Pull Request: ManageIQ/manageiq#23647
|
cross-repo is 🟢 |
jrafanie
reviewed
Nov 4, 2025
| gem "rest-client", "~>2.1.0", :require => false | ||
| gem "ruby_parser", :require => false # Required for i18n string extraction, and DescentdantLoader (via prism) | ||
| gem "ruby-progressbar", "~>1.7.0", :require => false | ||
| gem "rubyzip", "~>2.0.0", :require => false |
jrafanie
reviewed
Nov 4, 2025
| - GUID | ||
| - VERSION | ||
| :ping_depot: true | ||
| :ping_depot_timeout: 20 |
There was a problem hiding this comment.
will the migration handle the removal of these sections in addition to the product features?
There was a problem hiding this comment.
good call - I'll add that too
There was a problem hiding this comment.
Updated the OP to remind me to include that.
jrafanie
approved these changes
Nov 4, 2025
|
Merging. The migration to drop existing setting changes (with the settings removed here) and roles using the removed product features can be done as a followup. I don't think this will break anything to merge. 💣 |
Fryguy
added a commit
to Fryguy/manageiq
that referenced
this pull request
Nov 4, 2025
Follow up to ManageIQ#23647. This drops the FileDepot#miq_schedules linkage, and also drops FileDepotFtp and FileDepotFtpAnonymous, since the only user of FileDepot stuff, PxeServer, doesn't support Ftp. By extension this also drops the net-ftp gem.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In containerized deployments we can't support log collection, because we can't mount the log depot. In appliance deployments, we're trying to get away from the application UI having anything to do with the system it's running on to avoid the need to elevate permissions. As such, this commit removes log collection from backend. The UI will be done separately.
Instead, on appliances, users can manually mount an NFS server (or really any server type - even more than our UI supports), and then use the /var/www/miq/vmdb/tools/collect_logs tool. If the user needs scheduling, they can schedule a cron on the appliance to run the tool.
Depends on:
@jrafanie Please review.
Follow up: