Drop log collection tables, columns, and configuration #820
+118
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There might be more to delete after ManageIQ/manageiq#23649 |
jrafanie
reviewed
Nov 5, 2025
| end | ||
|
|
||
| say_with_time("Removing log collection settings") do | ||
| SettingsChange.in_my_region.where("key LIKE ?", "/log/collection%").delete_all |
There was a problem hiding this comment.
wow, this is so clean... I thought it would be more to do but I think you're right, this is it. 👍
Fryguy
commented
Nov 5, 2025
Comment on lines
18
to
19
| t.datetime :created_on | ||
| t.datetime :updated_on |
There was a problem hiding this comment.
Just want to check this - think I need it to be slightly different
There was a problem hiding this comment.
Ok, this is good now - I ran a db:migrate right before this one, and then copied the log_files definition from db/schema.rb. This is more accurate now.
Fryguy
force-pushed
the
drop_log_collection
branch
from
e9f02c0 to
636b547
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jrafanie Please review.
Depends on