Updates for ConfigurationScript Service UI #23637
Merged
+33
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
agrare
commented
Oct 23, 2025
agrare
commented
Oct 23, 2025
| classy = find_matching_constant("ManageIQ::Providers::#{platform}") ? platform : platform.classify | ||
| vendor = find_matching_constant("ManageIQ::Providers::#{platform}") ? platform : platform.classify | ||
|
|
||
| find_matching_constant("MiqProvision#{classy}Workflow") || |
There was a problem hiding this comment.
NOTE I don't think this "ever" worked because e.g. MiqProvisionCloudWorkflow is an alias, so "MiqProvisionCloudWorkflow".safe_constantize&.name == "MiqProvisionCloudWorkflow" is never true.
"MiqProvisionCloudWorkflow".safe_constantize => ManageIQ::Providers::CloudManager::ProvisionWorkflow
agrare
force-pushed
the
miq_provision_configuration_script_service_catalog_ui
branch
from
5ba54e8 to
bd6963d
Compare
agrare
changed the title
agrare
force-pushed
the
miq_provision_configuration_script_service_catalog_ui
branch
from
d39da64 to
923d0fa
Compare
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Oct 31, 2025
From Pull Request: ManageIQ/manageiq#23637
kbrock
reviewed
Oct 31, 2025
Fryguy
reviewed
Oct 31, 2025
agrare
force-pushed
the
miq_provision_configuration_script_service_catalog_ui
branch
from
55e4c55 to
7631f3e
Compare
Fryguy
reviewed
Oct 31, 2025
agrare
force-pushed
the
miq_provision_configuration_script_service_catalog_ui
branch
2 times, most recently
from
06bbe7a to
7631f3e
Compare
agrare
force-pushed
the
miq_provision_configuration_script_service_catalog_ui
branch
from
7631f3e to
043b578
Compare
Fryguy
approved these changes
Nov 3, 2025
agrare
deleted the
miq_provision_configuration_script_service_catalog_ui
branch
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates for the UI changes needed for the updates to the Service Catalog to allow EmbeddedWorkflows for AutomationManager provisioning.
I changed the
:source_idto:src_configuration_script_idbecause the UI checks the key in a few places and source_id was too generalRelated:
Cross-Repo Tests: ManageIQ/manageiq-cross_repo-tests#1000