-
Notifications
You must be signed in to change notification settings - Fork 4
MiqProvisionTask based workspace provision #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
91c90b8 to
1aced59
Compare
0d5046c to
ff6d84d
Compare
app/models/manageiq/providers/terraform_enterprise/automation_manager/provision_workflow.rb
Outdated
Show resolved
Hide resolved
f1e0aa5 to
849c265
Compare
849c265 to
8bce36f
Compare
| @@ -0,0 +1,6 @@ | |||
| class ManageIQ::Providers::TerraformEnterprise::AutomationManager::ProvisionWorkflow < ManageIQ::Providers::AutomationManager::ProvisionWorkflow | |||
| def dialog_name_from_automate(message = 'get_dialog_name', extra_attrs = {}) | |||
| extra_attrs['platform_category'] ||= 'terraform_enterprise' | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be automation...probably need to change the other pr(s) to match
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you search the other models for this key, I see that platform_category is set to a generic category in the base class (e.g. extra_attrs['platform_category'] = "cloud" in the base Cloud::ProvisionWorkflow), and then in the actual providers they have platform set to something specific, e.g. extra_attrs['platform'] = "ibm_cloud"
8bce36f to
9001ab2
Compare
9001ab2 to
043617e
Compare
a7f298d to
39a47d7
Compare
1725335 to
f3ad057
Compare
971e22e to
915e6c1
Compare
915e6c1 to
2c69852
Compare
2c69852 to
a7c377e
Compare
| def self.default_provisioning_entry_point(_service_type) | ||
| '/AutomationManagement/TerraformEnterprise/Service/Provisioning/StateMachines/Provision/CatalogItemInitialization' | ||
| end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does removing this now prevent the UI from doing automate based provisioning? Or maybe not prevent, but the user would have to know to put this into the field?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not. Previously there was no way for the user to select anything except the above value. Now the user has the same options as vm provisioning to select automate or workflows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

Adds
ServiceTemplateTerraformEnterprisechanges for creating a RequestTemplate that supports running theTerraformEnterprise::AutomationManager::Provisionthrough workflows.To create a
ServiceTemplate:Related: