[calendar] test: remove "Recurring event per timezone" test #3929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the "Recurring event per timezone" test that manipulated Date.prototype.getTimezoneOffset to simulate 24 different timezones for testing all-day recurring events. Reasons for removal: 1. The test approach is incompatible with node-ical 0.22.0's Intl-based timezone handling (which replaced moment-timezone). Manipulating Date.prototype.getTimezoneOffset no longer affects Intl.DateTimeFormat, which reads the system timezone directly. 2. node-ical 0.22.0 handles all-day events (VALUE=DATE) correctly by preserving the calendar date without timezone conversions, making cross-timezone testing unnecessary. The library includes comprehensive tests for this behavior, particularly "keeps whole-day recurrence across DST" in test/advanced.test.js. 3. The existing "Recurring event" test already verifies that recurring events from the same ICS file are displayed correctly, so a simplified version of this test is not necessary. The old test attempted to work around timezone conversion issues in node-ical 0.21.0 that are now properly resolved upstream. Closes MagicMirrorOrg#3928
khassel
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the "Recurring event per timezone" test that manipulated Date.prototype.getTimezoneOffset to simulate 24 different timezones for testing all-day recurring events.
Reasons for removal:
The test approach is incompatible with node-ical 0.22.0's Intl-based timezone handling (which replaced moment-timezone). Manipulating Date.prototype.getTimezoneOffset no longer affects Intl.DateTimeFormat, which reads the system timezone directly.
node-ical 0.22.0 handles all-day events (VALUE=DATE) correctly by preserving the calendar date without timezone conversions, making cross-timezone testing unnecessary. The library includes comprehensive tests for this behavior, particularly "keeps whole-day recurrence across DST" in test/advanced.test.js.
The existing "Recurring event" test already verifies that recurring events from the same ICS file are displayed correctly, so a simplified version of "Recurring event per timezone" is not necessary.
The old test attempted to work around timezone conversion issues in node-ical 0.21.0 that are now properly resolved upstream.
Closes #3928