Skip to content

Commit c9eecdd

Browse files
[calendar] test: remove "Recurring event per timezone" test (#3929)
Remove the "Recurring event per timezone" test that manipulated Date.prototype.getTimezoneOffset to simulate 24 different timezones for testing all-day recurring events. Reasons for removal: 1. The test approach is incompatible with node-ical 0.22.0's Intl-based timezone handling (which replaced moment-timezone). Manipulating Date.prototype.getTimezoneOffset no longer affects Intl.DateTimeFormat, which reads the system timezone directly. 2. node-ical 0.22.0 handles all-day events (VALUE=DATE) correctly by preserving the calendar date without timezone conversions, making cross-timezone testing unnecessary. The library includes comprehensive tests for this behavior, particularly "keeps whole-day recurrence across DST" in [test/advanced.test.js](https://github.com/jens-maus/node-ical/blob/master/test/advanced.test.js). 3. The existing "Recurring event" test already verifies that recurring events from the same ICS file are displayed correctly, so a simplified version of "Recurring event per timezone" is not necessary. The old test attempted to work around timezone conversion issues in node-ical 0.21.0 that are now properly resolved upstream. Closes #3928
1 parent bc0d365 commit c9eecdd

File tree

2 files changed

+1
-16
lines changed

2 files changed

+1
-16
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ planned for 2026-01-01
1818
### Changed
1919

2020
- [core] refactor: replace `module-alias` dependency with internal alias resolver (#3893)
21+
- [calendar] test: remove "Recurring event per timezone" test (#3929)
2122

2223
### Fixed
2324

tests/e2e/modules/calendar_spec.js

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -119,22 +119,6 @@ describe("Calendar module", () => {
119119
});
120120
});
121121

122-
for (let i = -12; i < 12; i++) {
123-
describe("Recurring event per timezone", () => {
124-
beforeAll(async () => {
125-
Date.prototype.getTimezoneOffset = () => {
126-
return i * 60;
127-
};
128-
await helpers.startApplication("tests/configs/modules/calendar/recurring.js");
129-
await helpers.getDocument();
130-
});
131-
132-
it(`should contain text "Mar 25th" in timezone UTC ${-i}`, async () => {
133-
await expect(testTextContain(".calendar", "Mar 25th")).resolves.toBe(true);
134-
});
135-
});
136-
}
137-
138122
describe("Changed port", () => {
139123
beforeAll(async () => {
140124
await helpers.startApplication("tests/configs/modules/calendar/changed-port.js");

0 commit comments

Comments
 (0)