Skip to content

Conversation

rejas
Copy link
Collaborator

@rejas rejas commented Oct 20, 2025

No description provided.

@rejas rejas marked this pull request as ready for review October 20, 2025 17:48
@khassel
Copy link
Collaborator

khassel commented Oct 20, 2025

@rejas I'm not good in nodejs so I'm asking if there maybe is a mechanism to automatically provide the filename into the log message instead of hard coding this everywhere?

@sdetweil
Copy link
Collaborator

on the web side
document.currentScript.src
and on the node side
__filename

@khassel
Copy link
Collaborator

khassel commented Oct 20, 2025

yes, but I was thinking about something where the logger.js could get the caller filename ...

@sdetweil
Copy link
Collaborator

yeh I have looked at that a number of times in different places, we need a macro that can capture that info in the calling code and pass it to the worker function.

@rejas
Copy link
Collaborator Author

rejas commented Oct 21, 2025

Having it done autoamtically would of course be nice, but maybe we just merge this, create a ticket with "PR welcome" for that idea and see who takes it?

@khassel khassel merged commit a1c1e95 into MagicMirrorOrg:develop Oct 21, 2025
9 checks passed
@rejas rejas deleted the log branch October 21, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants