-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
logger: add calling filename as prefix on server side #3926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Not sure the MagicMirror code prefix (app,server…) is useful, and certainly not double |
but do they hurt? I prefer to stay with this instead of implementing filters for removing.
yes, they should be removed. We could also think of renaming some files so it is clearer to what they belong, e.g. |
|
Doesn’t hurt. |
I like it 👍
You mean entries like Removed. What effect does that have on 3rd-party-modules? |
yes, and e.g.
searching for a good module to test this. Testing with mine gave most time Should have no negative effect, either a filename is displayed or otherwise |
|
we could also extract the module name (from the path) for 3rd-party-modules instead of dislaying the filename which will be 95% |
in that case the module name and current file name is really all thats important.. don't need to call tree |
|
Prefixes for modules would be a nice win. We'll have duplicates there too at first (because now some modules add own prefixes), but they'll gradually disappear. |
|
Looks good to me! 🙂 |
bc0d365
into
MagicMirrorOrg:develop


follow up to discussions in #3923
This small change adds the calling filename (path und suffix are stripped) to the log messages coming from server side, example screenshot:
I choosed grey as color for better readability.
Let me know if this change is wanted and if the duplicates in the default module log messages should stay or removed.
Links: