Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add all check #703

Merged
merged 4 commits into from
Mar 25, 2025
Merged

ci: add all check #703

merged 4 commits into from
Mar 25, 2025

Conversation

slabasan
Copy link
Collaborator

@slabasan slabasan commented Mar 25, 2025

Description

Add all check to allow for required checks that can be passed or skipped but not failed.

@slabasan slabasan added the ci CI, unit tests, GitHub actions label Mar 25, 2025
@slabasan slabasan requested a review from alecbcs March 25, 2025 16:42
@alecbcs
Copy link
Member

alecbcs commented Mar 25, 2025

I would add *.patch to the existing set of skips in the configuration file here instad of modifying the CI scripts.

skip = './docs/_build,./docs/_static,./taxonomy.yaml'
.

@slabasan slabasan force-pushed the codespell-skip-patch branch from 109b97f to 9db91ed Compare March 25, 2025 16:48
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Mar 25, 2025
@slabasan
Copy link
Collaborator Author

Fixed, thanks @alecbcs. That's a better place to change it.

@slabasan slabasan mentioned this pull request Mar 25, 2025
10 tasks
pearce8
pearce8 previously approved these changes Mar 25, 2025
@pearce8 pearce8 enabled auto-merge March 25, 2025 20:34
@alecbcs alecbcs changed the title codespell: ignore patch files ci: add all check to allow for required checks that can be passed or skipped but not failed Mar 25, 2025
@alecbcs alecbcs changed the title ci: add all check to allow for required checks that can be passed or skipped but not failed ci: add all check Mar 25, 2025
@alecbcs alecbcs enabled auto-merge March 25, 2025 21:58
@alecbcs alecbcs disabled auto-merge March 25, 2025 21:58
@alecbcs alecbcs merged commit 4d0468f into develop Mar 25, 2025
12 checks passed
@alecbcs alecbcs deleted the codespell-skip-patch branch March 25, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CI, unit tests, GitHub actions dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants