Experiment/salmon #619

slabasan · 2025-02-14T15:07:43Z

Depends on #703 to pass lint CI checks.

~~Blocked by:~~

~~Update version of Spack #623 -- debug errors when updating spack version~~ Remove depends_on() and no longer need a newer spack
~~Babelstream package in benchpark vs updated in spack~~ Fixed in develop

Description

Add salmon experiment
Replaces Fix legacy salmon and add experiment class for salmon #391, moves branch to upstream so CI tests run

Adding/modifying a benchmark (docs: Adding a Benchmark)

If modifying the source code of a benchmark: create, self-assign, and link here a follow up issue with a link to the PR in the benchmark repo.
If package.py upstreamed to Spack is insufficient, add/modify repo/benchmark_name/package.py plus: create, self-assign, and link here a follow up issue with a link to the PR in the Spack repo.
If application.py upstreamed to Ramble is insufficient, add/modify repo/benchmark_name/application.py plus: create, self-assign, and link here a follow up issue with a link to the PR in the Ramble repo.
Tags in Ramble's application.py or in repo/benchmark_name/application.py will appear in the docs catalogue
Add/modify an experiments/benchmark_name/experiment.py to define a single node and multi-node experiments
Add/modify a dry run unit test in .github/workflows/run.yml

checkout-versions.yaml

pearce8 · 2025-02-18T00:51:01Z

@slabasan What was the reason to pull in a new version of Spack here? I think it is causing some of the issues with your tests, so I pulled out the version update into its own PR #623 to try to figure that part out.

* Remove legacy experiment, modifier, and system checks * Migrate legacy CI to use current workflow * Omit experiment that has not been migrated yet #619 * Fix path for dynamic dry run * Fix saxpy/openmp test * Initialize fugaku system in qws/openmp * Fix bug by changing benchmark to system * Remove legacy modifier config * Unlink legacy modifier --------- Co-authored-by: Mckinsey <[email protected]> Co-authored-by: Michael Richard Mckinsey <[email protected]>

repo/salmon-tddft/package.py

experiments/salmon-tddft/experiment.py

slabasan · 2025-03-25T01:01:29Z

The lint CI check caught a mis-spelling of optimization in repo/salmon_tddft/fjmpi.patch. But is also thinking that nd is a mis-spelled 2nd. This is a false positive error. Should lint CI be checking these files?

Update: I've updated our github actions to ignore applying codespell to patch files. These files seem out of scope for benchpark.

michaelmckinsey1

Looks good once lint passing

Co-authored-by: Alec Scott <[email protected]>

use a consistent compiler between ruby and fugaku

remove variant from application.py file

- openmp is not a package in spack, so cannot depend_on() - add fallow-argument-mismatch flag for gcc10 and later

remove depends_on calls in salmon's package.py to avoid needing newer spack version

slabasan · 2025-03-25T20:46:43Z

This one is (finally) ready!

dyokelson

Do we want all the tests in the run.yml or just in the new format? Just not sure if lines 265-285 are still needed or it would be best to just keep the later versions.

We should have the Riken folks test this out on Fugaku as well.

github-actions bot added experiment New or modified experiment ci CI, unit tests, GitHub actions application labels Feb 14, 2025

pearce8 reviewed Feb 17, 2025

View reviewed changes

checkout-versions.yaml Outdated Show resolved Hide resolved

pearce8 mentioned this pull request Feb 18, 2025

Update version of Spack #623

Open

9 tasks

slabasan mentioned this pull request Feb 18, 2025

Fix legacy salmon and add experiment class for salmon #391

Closed

slabasan added the WIP A work-in-progress not yet ready to commit label Feb 18, 2025

michaelmckinsey1 pushed a commit that referenced this pull request Feb 21, 2025

Omit experiment that has not been migrated yet #619

e48e80b

michaelmckinsey1 mentioned this pull request Feb 19, 2025

Retire Legacy Experiments and Systems #531

Open

slabasan commented Mar 24, 2025

View reviewed changes

repo/salmon-tddft/package.py Outdated Show resolved Hide resolved

slabasan force-pushed the experiment/salmon branch 7 times, most recently from 2323bfc to 028b6c3 Compare March 24, 2025 23:29

michaelmckinsey1 requested changes Mar 24, 2025

View reviewed changes

experiments/salmon-tddft/experiment.py Outdated Show resolved Hide resolved

slabasan force-pushed the experiment/salmon branch from 028b6c3 to 98420cf Compare March 25, 2025 00:54

slabasan force-pushed the experiment/salmon branch from 98420cf to 67524e9 Compare March 25, 2025 01:07

slabasan requested review from pearce8 and michaelmckinsey1 March 25, 2025 06:12

slabasan force-pushed the experiment/salmon branch from a323392 to db2ba9b Compare March 25, 2025 16:42

michaelmckinsey1 previously approved these changes Mar 25, 2025

View reviewed changes

slabasan and others added 3 commits March 25, 2025 09:48

codespell: ignore patch files

9db91ed

use double asterisk wildcard

45726cf

Co-authored-by: Alec Scott <[email protected]>

change to default-compiler, try out on dane tomorrow

3f91f12

dyokelson and others added 16 commits March 25, 2025 13:43

Add CI on x86 and default-compiler to cmake

a5bcd86

remove .tpl file

96a3651

running on ruby

90c685d

use a consistent compiler between ruby and fugaku

add salmon application.py

7c9a37a

add dynamic dry runs on ruby and fugaku

59caab0

rename salmon directory, class and format

a3daf38

salmon: add openmp variant

bc21cce

add local salmon package and patches

db317c1

remove variant from application.py file

fix spack package name for salmon

587f904

salmon package.py and experiment.py fixes

b9d817c

- openmp is not a package in spack, so cannot depend_on() - add fallow-argument-mismatch flag for gcc10 and later

rebase and update

ea18c23

remove depends_on calls in salmon's package.py to avoid needing newer spack version

move salmon tests to end of dryrunexperiments section in run.yml

5182a78

add experiment setup

7a23cbf

remove second call to create salmon/openmp dir

d5a95a0

remove duplicate fugaku system init

ff486a9

removing experiment handles, change already merged into develop

3bd93a2

slabasan dismissed michaelmckinsey1’s stale review via 3bd93a2 March 25, 2025 20:43

slabasan force-pushed the experiment/salmon branch from db2ba9b to 3bd93a2 Compare March 25, 2025 20:43

github-actions bot added the dependencies Pull requests that update a dependency file label Mar 25, 2025

slabasan requested a review from dyokelson March 25, 2025 20:46

dyokelson reviewed Mar 25, 2025

View reviewed changes

black

465068d

pearce8 approved these changes Mar 25, 2025

View reviewed changes

pearce8 added this pull request to the merge queue Mar 25, 2025

Merged via the queue into develop with commit 43df7c2 Mar 25, 2025
11 checks passed

pearce8 deleted the experiment/salmon branch March 25, 2025 21:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Experiment/salmon #619

Experiment/salmon #619

slabasan commented Feb 14, 2025 •

edited by pearce8

Loading

pearce8 commented Feb 18, 2025

slabasan commented Mar 25, 2025 •

edited

Loading

michaelmckinsey1 left a comment

slabasan commented Mar 25, 2025

dyokelson left a comment

Experiment/salmon #619

Experiment/salmon #619

Conversation

slabasan commented Feb 14, 2025 • edited by pearce8 Loading

Description

Adding/modifying a benchmark (docs: Adding a Benchmark)

pearce8 commented Feb 18, 2025

slabasan commented Mar 25, 2025 • edited Loading

michaelmckinsey1 left a comment

Choose a reason for hiding this comment

slabasan commented Mar 25, 2025

dyokelson left a comment

Choose a reason for hiding this comment

slabasan commented Feb 14, 2025 •

edited by pearce8

Loading

slabasan commented Mar 25, 2025 •

edited

Loading