-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/node 4923 refactor upgrade tests to use local configurations #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: keysets
Are you sure you want to change the base?
Feature/node 4923 refactor upgrade tests to use local configurations #60
Conversation
…to-use-local-configurations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request refactors upgrade tests to use local configurations instead of remote branch-based testing. The key changes include:
- Simplified upgrade testing approach using local release binaries instead of fetching builds from remote branches
- Method renaming for consistency:
get_validator_by_idx→get_validator_by_indexandget_validator_by_idx_mut→get_validator_by_index_as_mut - Extraction of invalid version tests into a separate module
- Addition of temporary backward compatibility code for DKG ID generation to support upgrade from version 2.1.5 to 2.1.6+
- Contract schema updates to add a deprecated
key_types_deprecatedfield toGlobalConfig - Implementation of
Clonetraits for test infrastructure types
Reviewed changes
Copilot reviewed 26 out of 30 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| rust/lit-node/shiva/src/testnet_instance.rs | Updated validator accessor method name |
| rust/lit-node/lit-node/tests/upgrades/version_upgrades.rs | Major refactoring: simplified upgrade test to use local binaries, removed complex alias wallet logic |
| rust/lit-node/lit-node/tests/upgrades/mod.rs | Added new invalid_version module |
| rust/lit-node/lit-node/tests/upgrades/invalid_version.rs | Moved invalid version tests to separate module |
| rust/lit-node/lit-node/tests/integration/signing.rs | Removed test configuration line (whitespace cleanup) |
| rust/lit-node/lit-node/tests/integration/epoch_change_long.rs | Updated validator accessor method name |
| rust/lit-node/lit-node/tests/integration/backup_long.rs | Updated validator accessor method names |
| rust/lit-node/lit-node/tests/integration/backup_datil_long.rs | Updated validator accessor method name |
| rust/lit-node/lit-node/tests/common/web_user_tests.rs | Uncommented assertion code |
| rust/lit-node/lit-node/tests/common/peers.rs | Updated validator accessor method name |
| rust/lit-node/lit-node/tests/common/assertions.rs | Removed unused imports and deprecated test method |
| rust/lit-node/lit-node/src/tss/dkg/manager.rs | Added temporary version check for DKG ID compatibility |
| rust/lit-node/lit-node/src/peers/peer_state/models.rs | Added has_version_lower_than method |
| rust/lit-node/lit-node/src/git_info.rs | Updated git commit hash |
| rust/lit-node/lit-node-testnet/src/validator.rs | Added Clone implementations and new methods |
| rust/lit-node/lit-node-testnet/src/testnet/contracts.rs | Added key_types_deprecated field |
| rust/lit-core/lit-blockchain/src/contracts/staking.rs | Updated contract bindings for GlobalConfig changes |
| rust/lit-core/lit-blockchain/abis/Staking.json | Added key_types_deprecated field to GlobalConfig |
| rust/lit-core/lit-blockchain-lite/src/contracts/staking.rs | Updated contract bindings for GlobalConfig changes |
| rust/lit-core/lit-blockchain-lite/abis/Staking.json | Added key_types_deprecated field to GlobalConfig |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
PASS [ 86.471s] (1/3) lit_node::test toxiproxy::perf_tests::load_with_50ms_latency_all_links |
…to-use-local-configurations
…to-use-local-configurations
…move curves, change yaml files ).
…to-use-local-configurations
Pull request overview
This pull request refactors upgrade tests to use local configurations instead of remote branch-based testing. The key changes include:
get_validator_by_idx→get_validator_by_indexandget_validator_by_idx_mut→get_validator_by_index_as_mutkey_types_deprecatedfield toGlobalConfigClonetraits for test infrastructure typesNOTES:
network checkerfunctionality is disabled at the moment. There seems to be some discrepancy in signing ( though not encryption ! ) that happens while the nodes are at different versions.