Skip to content

Conversation

@GTC6244
Copy link
Contributor

@GTC6244 GTC6244 commented Jan 6, 2026

WHAT

Removes traces of custom version upgrade code that appears in YML files. Version upgrade tests will be run directly from code, allowing us test based on branches, rather than re-writing yml files per branch, then ignoring them when done.

@GTC6244 GTC6244 self-assigned this Jan 6, 2026
Copilot AI review requested due to automatic review settings January 6, 2026 15:26
@GTC6244 GTC6244 added the keysets label Jan 6, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the custom version upgrade testing infrastructure from GitHub workflow files. The version upgrade tests are being migrated to run directly from code instead of being managed through YAML configurations, allowing for branch-based testing rather than file modifications.

  • Removes the lit_node_version_upgrade_tests job from the group test workflow
  • Cleans up all references to the version upgrade tests workflow file
  • Updates job dependencies and status checks to exclude the removed job

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
rust/lit-node/lit-node/src/git_info.rs Updates git commit hash (auto-generated change)
.github/workflows/rust-lit-node-group-unit-and-integration-tests.yml Removes the entire version upgrade tests job, its dependencies, and status checks; removes workflow trigger path reference
.github/workflows/list-changed-files.yml Removes version upgrade tests workflow from the changed files detection list

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

PASS [ 43.253s] (3/3) lit_node::test toxiproxy::perf_tests::load_with_no_latency
PASS [ 43.459s] (2/3) lit_node::test toxiproxy::perf_tests::load_with_50ms_latency_single_link
PASS [ 85.159s] (1/3) lit_node::test toxiproxy::perf_tests::load_with_50ms_latency_all_links

Copy link

@DashKash54 DashKash54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Straightforward but why are we removing running these test from the CI?
  2. Can you also link the other version upgrade tests that you mention- "Version upgrade tests will be run directly from code"

@GTC6244
Copy link
Contributor Author

GTC6244 commented Jan 9, 2026

  1. Straightforward but why are we removing running these test from the CI?
  2. Can you also link the other version upgrade tests that you mention- "Version upgrade tests will be run directly from code"
  1. The architecture is awkward. Basically every time we want to run an upgrade test, we'd need to change a bunch of yaml files. This was basically set up "as-is" and never changed. We should be able to simply write a test without relying on the setup in CI to ensure that it can run.

  2. Sure -> Feature/node 4923 refactor upgrade tests to use local configurations #60

@GTC6244 GTC6244 merged commit 1ddd393 into keysets Jan 9, 2026
17 checks passed
@GTC6244 GTC6244 deleted the feature/node-4920-remove-logic-from-ci-that-determines-which-updates-to-be branch January 9, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants