Skip to content

🔀 merge queue onboarding #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 31, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion .github/workflows/code-style.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
---
name: Code Style

on: pull_request
on:
pull_request: {}

merge_group:
types: [checks_requested]

jobs:
lint:
Expand All @@ -21,3 +25,15 @@ jobs:
- name: run lint test
run: |
make run-lint
required-checks:
name: Code Style Required Checks
# This check adds a list of checks to one job to simplify adding settings to the repo.
# If a new check is added in this file, and it should be retested on entry to the merge queue,
# it needs to be added to the list below aka needs: [ existing check 1, existing check 2, new check ].
needs:
- lint
if: always()
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- run: echo '${{ toJSON(needs) }}' | jq -e 'all(.[]; .result == "success" or .result == "skipped")'
24 changes: 20 additions & 4 deletions .github/workflows/commands.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,17 @@ name: Command Testing

on:
push:
branches: [ 'main' ]
branches: ['main']

pull_request:
branches: [ '*' ]
branches: ['*']

merge_group:
types: [checks_requested]

jobs:
install:
name: Run kuadrantctl generate
generate-httproute:
name: Run kuadrantctl generate gatewayapi httproute
runs-on: ubuntu-latest
env:
KIND_CLUSTER_NAME: kuadrantctl-local
Expand All @@ -28,3 +31,16 @@ jobs:
- name: run command
run: |
bin/kuadrantctl generate gatewayapi httproute --oas examples/oas3/gateway-api-petstore.yaml

required-checks:
name: Command Testing Required Checks
# This check adds a list of checks to one job to simplify adding settings to the repo.
# If a new check is added in this file, and it should be retested on entry to the merge queue,
# it needs to be added to the list below aka needs: [ existing check 1, existing check 2, new check ].
needs:
- generate-httproute
if: always()
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- run: echo '${{ toJSON(needs) }}' | jq -e 'all(.[]; .result == "success" or .result == "skipped")'
21 changes: 19 additions & 2 deletions .github/workflows/testing.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,13 @@ name: Testing

on:
push:
branches: [ 'main' ]
branches: ['main']

merge_group:
types: [checks_requested]

pull_request:
branches: [ '*' ]
branches: ['*']

jobs:
build:
Expand Down Expand Up @@ -50,3 +53,17 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
fail_ci_if_error: false
verbose: true

required-checks:
name: Testing Required Checks
# This check adds a list of checks to one job to simplify adding settings to the repo.
# If a new check is added in this file, and it should be retested on entry to the merge queue,
# it needs to be added to the list below aka needs: [ existing check 1, existing check 2, new check ].
needs:
- build
- tests
if: always()
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- run: echo '${{ toJSON(needs) }}' | jq -e 'all(.[]; .result == "success" or .result == "skipped")'
Loading