Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔀 merge queue onboarding #114

Merged
merged 2 commits into from
Jan 31, 2025
Merged

🔀 merge queue onboarding #114

merged 2 commits into from
Jan 31, 2025

Conversation

eguzki
Copy link
Collaborator

@eguzki eguzki commented Jan 31, 2025

Work done as part of Kuadrant/kuadrant#7

Not really useful for this repo (as of today), but it's good to be aligned with other kuadrant repos.

Signed-off-by: Eguzki Astiz Lezaun <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.57%. Comparing base (7296e1b) to head (5d16867).
Report is 76 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##            main     #114       +/-   ##
==========================================
+ Coverage   0.38%   54.57%   +54.19%     
==========================================
  Files         17       17               
  Lines        783      885      +102     
==========================================
+ Hits           3      483      +480     
+ Misses       780      330      -450     
- Partials       0       72       +72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eguzki eguzki self-assigned this Jan 31, 2025
@eguzki eguzki added enhancement New feature or request good first issue Good for newcomers labels Jan 31, 2025
Signed-off-by: Eguzki Astiz Lezaun <[email protected]>
Copy link

@laurafitzgerald laurafitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. On a not so active repo the testing against other changes might not come into play too often. You will get testing against up to date main. And of course you can hit the button and walk away, if that's something that's important to you. :)

@eguzki eguzki merged commit 146330d into main Jan 31, 2025
9 checks passed
@eguzki eguzki deleted the merge-queue branch January 31, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants