Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add helix from params endpoint #678

Merged
merged 5 commits into from
Dec 17, 2024
Merged

add helix from params endpoint #678

merged 5 commits into from
Dec 17, 2024

Conversation

gserena01
Copy link
Contributor

@gserena01 gserena01 commented Dec 13, 2024

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@ae30c32). Learn more about missing BASE report.

Files with missing lines Patch % Lines
modeling-cmds/src/def_enum.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #678   +/-   ##
=======================================
  Coverage        ?   27.76%           
=======================================
  Files           ?       35           
  Lines           ?     1905           
  Branches        ?        0           
=======================================
  Hits            ?      529           
  Misses          ?     1376           
  Partials        ?        0           
Flag Coverage Δ
unittests 27.76% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gserena01 gserena01 marked this pull request as ready for review December 13, 2024 21:38
modeling-cmds/src/def_enum.rs Outdated Show resolved Hide resolved
modeling-cmds/src/def_enum.rs Outdated Show resolved Hide resolved
modeling-cmds/src/def_enum.rs Outdated Show resolved Hide resolved
@gserena01 gserena01 merged commit 117ee9b into main Dec 17, 2024
9 checks passed
@gserena01 gserena01 deleted the serena/helix-params branch December 17, 2024 18:56
gserena01 added a commit that referenced this pull request Dec 17, 2024
adamchalmers pushed a commit that referenced this pull request Dec 17, 2024
# Added

 - New command `EntityMakeHelixFromParams` #678

Co-authored-by: gserena <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants