Skip to content

Commit

Permalink
Revert "add helix from params endpoint (#678)"
Browse files Browse the repository at this point in the history
This reverts commit 117ee9b.
  • Loading branch information
gserena01 authored Dec 17, 2024
1 parent 117ee9b commit 27e8e54
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 27 deletions.
23 changes: 1 addition & 22 deletions modeling-cmds/src/def_enum.rs
Original file line number Diff line number Diff line change
Expand Up @@ -403,35 +403,14 @@ define_modeling_cmd_enum! {
pub cylinder_id: Uuid,
/// Number of revolutions.
pub revolutions: f64,
/// Start angle.
#[serde(default)]
/// Start angle (in degrees).
pub start_angle: Angle,
/// Is the helix rotation clockwise?
pub is_clockwise: bool,
/// Length of the helix.
pub length: LengthUnit,
}

/// Create a helix using the specified parameters.
#[derive(Debug, Clone, Serialize, Deserialize, JsonSchema, ModelingCmdVariant)]
pub struct EntityMakeHelixFromParams {
/// Radius of the helix.
pub radius: f64,
/// Length of the helix.
pub length: LengthUnit,
/// Number of revolutions.
pub revolutions: f64,
/// Start angle.
#[serde(default)]
pub start_angle: Angle,
/// Is the helix rotation clockwise?
pub is_clockwise: bool,
/// Center of the helix at the base of the helix.
pub center: Point3d<LengthUnit>,
/// Axis of the helix. The helix will be created around and in the direction of this axis.
pub axis: Point3d<f64>,
}

/// Mirror the input entities over the specified axis. (Currently only supports sketches)
#[derive(Debug, Clone, Serialize, Deserialize, JsonSchema, ModelingCmdVariant)]
pub struct EntityMirror {
Expand Down
5 changes: 0 additions & 5 deletions modeling-cmds/src/ok_response.rs
Original file line number Diff line number Diff line change
Expand Up @@ -89,11 +89,6 @@ define_ok_modeling_cmd_response_enum! {
pub struct EntityMakeHelix {
}

/// The response from the `EntityMakeHelixFromParams` endpoint.
#[derive(Debug, Serialize, Deserialize, Clone, JsonSchema, ModelingCmdOutput)]
pub struct EntityMakeHelixFromParams {
}

/// The response from the `EntityMirror` endpoint.
#[derive(Debug, Serialize, Deserialize, Clone, JsonSchema, ModelingCmdOutput)]
pub struct EntityMirror {
Expand Down

0 comments on commit 27e8e54

Please sign in to comment.