-
Notifications
You must be signed in to change notification settings - Fork 226
Task14 #818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
stillwearit
wants to merge
13
commits into
KFalcon2022:master
Choose a base branch
from
stillwearit:task14
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Task14 #818
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
c83ea1a
?
stillwearit 2810432
готово?
stillwearit 03a0f2e
пробуем
stillwearit a9a6544
пробуем
stillwearit 22b5ab2
пробуем
stillwearit bdb4cd6
пробуем
stillwearit 606a7e1
пробуем
stillwearit 180677a
пробуем
stillwearit e1953e9
готово
stillwearit e55fabf
готово
stillwearit 49f0443
готово
stillwearit a5f5095
исправила
stillwearit d959219
готово
stillwearit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
аналогично замечаниям в предыдущих ПРах. Валидация так полноценно и не выделена из логики обработки. Ожидаю, что валидация будет происходить ДО запуска цикла, производящего полезную работу - в данном случае, подсчет объектов, попадающих в радары