Task14 #818
Open
Task14 #818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KFalcon2022
requested changes
Feb 4, 2025
| int[] objectCounts = new int[radars.length]; | ||
| for (int i = 0; i < radars.length; i++) { | ||
| int object = 0; | ||
| if (radars[i].length != 3 || radars[i][2] < 1) { |
There was a problem hiding this comment.
валидацию стоит отделять от остальной логики. Во-первых, это улучшит читабельность, во-вторых, ты лишишься риска обработать почти весь массив данных и лишь в конце узнать, что они не валидны
| } | ||
|
|
||
| objectCounts[i] = object; | ||
|
|
KFalcon2022
requested changes
Feb 17, 2025
| } | ||
|
|
||
| for (int j = 0; j < objectLocations.length; j++) { | ||
| if (!isValidObjects(objectLocations[j])) { |
There was a problem hiding this comment.
аналогично замечаниям в предыдущих ПРах. Валидация так полноценно и не выделена из логики обработки. Ожидаю, что валидация будет происходить ДО запуска цикла, производящего полезную работу - в данном случае, подсчет объектов, попадающих в радары
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.