-
Notifications
You must be signed in to change notification settings - Fork 82
qtypes: add support for Qt alias types that don't match #904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e8826f5
to
e409d32
Compare
e409d32
to
e5daff8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #904 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 71 71
Lines 11967 11967
=========================================
Hits 11967 11967 ☔ View full report in Codecov by Sentry. |
debf9b7
to
79cc8fe
Compare
6a21207
to
c67af09
Compare
c67af09
to
709d25d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good.
Naming wise I would just copy Qts casing (so lowercase). These types are quiet "fundamental types", which even in Rust are lowercase (i64, isize, etc.).
A sort-off open question is still how many operations we want to support on these...
Do we basically just enable From/Into
and call it a day, or do we want to have support for using the type more directly, like support for +-*/
on qint64...
For now it's probably good enough if we just have them convertable to their inner type, but something to keep in mind.
On the same note: Maybe we don't want to support Deref on these types?
It may be weird if you call e.g. abs
on qint64, but get an i64 back...
And now it would be a breaking change for us to add our own abs
method that returns qint64...
So it seems like limiting the API to just From/To with some derives is maybe best?
f2bf8e6
to
91759c2
Compare
91759c2
to
35b1a6c
Compare
Some times don't match the Rust types so add these missing types. Closes KDAB#882
35b1a6c
to
741741f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approved after rebase
Closes #882