WIP: experiment of using cfg options for differing Qt types #926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahayzen-kdab
force-pushed
the
882-qtypes-cfg-versioning
branch
from
db33e5b to
5e8a217
Compare
ahayzen-kdab
force-pushed
the
882-qtypes-cfg-versioning
branch
from
5e8a217 to
eefff66
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #926 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 71 71
Lines 11928 11928
=========================================
Hits 11928 11928 ☔ View full report in Codecov by Sentry. |
Some times don't match the Rust types so add these missing types. Closes KDAB#882
ahayzen-kdab
force-pushed
the
882-qtypes-cfg-versioning
branch
from
eefff66 to
4b91445
Compare
|
this causes duplicate names in CXX, instead this should be handled by having different names in the CXX bridge then a wrapper in Rust to call the right one, or a wrapper in C++ like there is currently. Which means this change is irrelevant other than moving the casting of the type from C++ to Rust which could be done in a separate change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires #904 and a CXX patch to work.