Use shorter paths in the OUT_DIR #1253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described in KDAB#1237, on Windows we're sometimes hitting the 260 character limit for filepaths. This is mostly due to a lot of nesting by Qt Creator, Corrosion and Cargo who all include the target triple and other configuration information in the build path. However, we can at least reduce the character count a little bit on our part. For example, for qqmlengine.cxxqt.h, the path length is now reduced by ~40 characters from: out/cxx-qt-build/target/crates/cxx-qt-lib/include/cxx-qt-lib-internals/src/qml/qqmlengine.cxxqt.h to now: out/cxxqtbuild/include/private/src/qml/qqmlengine.cxxqt.h
LeonMatthesKDAB
added
⏮️ backport-candidate
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1253 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 73 73
Lines 12612 12612
=========================================
Hits 12612 12612 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #1237, on Windows we're sometimes hitting the 260 character limit
for filepaths.
This is mostly due to a lot of nesting by Qt Creator, Corrosion and
Cargo who all include the target triple and other configuration information in the
build path.
However, we can at least reduce the character count a little bit on our
part.
For example, for qqmlengine.cxxqt.h, the path length is now reduced by
~40 characters from:
out/cxx-qt-build/target/crates/cxx-qt-lib/include/cxx-qt-lib-internals/src/qml/qqmlengine.cxxqt.h
to now:
out/cxxqtbuild/include/private/src/qml/qqmlengine.cxxqt.h
Closes #1237