0.7.2 backports #1259
Merged
0.7.2 backports #1259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeonMatthesKDAB
force-pushed
the
0.7.2-backports
branch
from
dc76dc0 to
1da36b1
Compare
We effectively ignore if the unsafe is specified and always consider it to be safe.
As if the individual function is unsafe the block can also be unsafe without any change in behaviour.
C++Qt block and fn following their original unsafe. RustQt blocks - invokables forward the block or fn unsafe to the fn - signals follow the fn unsafe to the fn - inherit (and signals) require either block or fn Anything with pointers in the arguments requires unsafe on the fn as required by CXX.
Thanks to @whs31 for spotting the issue
As described in KDAB#1237, on Windows we're sometimes hitting the 260 character limit for filepaths. This is mostly due to a lot of nesting by Qt Creator, Corrosion and Cargo who all include the target triple and other configuration information in the build path. However, we can at least reduce the character count a little bit on our part. For example, for qqmlengine.cxxqt.h, the path length is now reduced by ~40 characters from: out/cxx-qt-build/target/crates/cxx-qt-lib/include/cxx-qt-lib-internals/src/qml/qqmlengine.cxxqt.h to now: out/cxxqtbuild/include/private/src/qml/qqmlengine.cxxqt.h
- `impl cxx_qt::Initialize for x {}` can now be written in the bridge as shorthand
- It is shorthand for `impl cxx_qt::Constructor<()> for x {}`
- Update book, qml_features and docs
* MSVC: Link Qt components to Release runtime * Windows CI: Build Qt6 in Debug To ensure we can actually build and run tests in Debug mode, run at least one Windows CI runner in Debug mode. * Document MSVC runtime mismatch issues * qml_multi_crates: Map config for Qt::Network
LeonMatthesKDAB
force-pushed
the
0.7.2-backports
branch
from
1da36b1 to
63c2e82
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 0.7.x #1259 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 71 71
Lines 12213 12289 +76
=========================================
+ Hits 12213 12289 +76 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The test coverage now fails on the error case of generate_rust_signals, which is likely due to changes in coverage instrumentation. Adding a corresponding test should fix it
LeonMatthesKDAB
force-pushed
the
0.7.2-backports
branch
from
30700ec to
d2a937d
Compare
LeonMatthesKDAB
force-pushed
the
0.7.2-backports
branch
from
85de9df to
8c2f4fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thus far this includes the following PRs:
In addition, the version has been bumped to 0.7.2: