Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
*.html
51 changes: 51 additions & 0 deletions .github/workflows/R-CMD-check.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
# Workflow derived from https://github.com/r-lib/actions/tree/v2/examples
# Need help debugging build failures? Start at https://github.com/r-lib/actions#where-to-find-help
on:
pull_request:
types:
- opened
- synchronize
- reopened
workflow_dispatch:

name: R-CMD-check

jobs:
R-CMD-check:
runs-on: ${{ matrix.config.os }}

name: ${{ matrix.config.os }} (${{ matrix.config.r }})

strategy:
fail-fast: false
matrix:
config:
- {os: macOS-latest, r: 'release'}
- {os: windows-latest, r: 'release'}
- {os: ubuntu-latest, r: 'devel', http-user-agent: 'release'}
- {os: ubuntu-latest, r: 'release'}
- {os: ubuntu-latest, r: 'oldrel-1'}

env:
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
R_KEEP_PKG_SOURCE: yes

steps:
- uses: actions/checkout@v2

- uses: r-lib/actions/setup-pandoc@v2

- uses: r-lib/actions/setup-r@v2
with:
r-version: ${{ matrix.config.r }}
http-user-agent: ${{ matrix.config.http-user-agent }}
use-public-rspm: true

- uses: r-lib/actions/setup-r-dependencies@v2
with:
extra-packages: any::rcmdcheck
needs: check

- uses: r-lib/actions/check-r-package@v2
with:
upload-snapshots: true
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,4 @@
..Rcheck/
docs
revdep/
.github/
*.Rcheck/
9 changes: 5 additions & 4 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,11 @@ Description: Provides user-friendly tools for calibration in survey sampling.
'icarus'. In addition to calibration (with linear, raking and logit methods),
'icarus' features functions for calibration on tight bounds and penalized
calibration.
Version: 0.3.2
Authors@R: c(person("Antoine Rebecq", role=c("aut","cre"),
email = "[email protected]"))
Maintainer: Antoine Rebecq <[email protected]>
Version: 0.3.3
Authors@R: c(person("Antoine Rebecq", role=c("aut"), email = "[email protected]", comment = "Creator"),
person("Khaled", "Larbi", role = "cre", email = "[email protected]"),
person("Institut national de la statistique et des études économiques", role = "cph"))
Maintainer: Khaled Larbi <[email protected]>
Depends:
R (>= 3.1.1)
License: GPL-3
Expand Down
4 changes: 4 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# icarus 0.3.3

* New maintainer

# icarus 0.3.2

## Bug fixes
Expand Down
19 changes: 12 additions & 7 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,18 +1,23 @@
## Test environments
* Ubuntu 20.04, R 4.3.0
* win-builder (devel and release)
* Linux Ubuntu: R-oldrelease, R-release and R-devel
* Windows: R-oldrelease, R-release and R-devel
* MacOS: R-release

## R CMD check results
There were no ERRORs or WARNINGs.

There was 1 NOTE:

* Possibly mis-spelled words in DESCRIPTION:
Reweights (2:23)
SAS (3:186)
logit (3:300)
```
* checking CRAN incoming feasibility ... [10s] NOTE
Maintainer: 'Khaled Larbi <[email protected]>'

New maintainer:
Khaled Larbi <[email protected]>
Old maintainer(s):
Antoine Rebecq <[email protected]>
```

These words aren't mis-spelled and text in DESCRIPTION didn't change since last submission.

## Downstream dependencies

Expand Down
2 changes: 2 additions & 0 deletions icarus.Rproj
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
Version: 1.0
ProjectId: 4ba73e09-93ad-4a8f-a434-67d41d4eadcd

RestoreWorkspace: Default
SaveWorkspace: Default
Expand All @@ -15,3 +16,4 @@ LaTeX: pdfLaTeX
BuildType: Package
PackageUseDevtools: Yes
PackageInstallArgs: --no-multiarch --with-keep.source
PackageCheckArgs: --as-cran
2 changes: 1 addition & 1 deletion tests/testthat/test_calibration_small_dataset.R
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ test_that("Penalized calibration checks out", {


test_that("Calibration on minimum bounds checks out", {

skip_if_not_installed("Rglpk")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a warning to make sure test don't pass silently without being executed anywhere

mar1 <- c("category",3,80,90,60)
mar2 <- c("sex",2,140,90,0)
mar3 <- c("department",2,100,130,0)
Expand Down
Loading