Skip to content

Transfert to inseefr #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
khaledlarbi merged 11 commits into from
Sep 5, 2025
Merged

Transfert to inseefr #15

khaledlarbi merged 11 commits into from
Sep 5, 2025

Conversation

@khaledlarbi
Copy link
Contributor

@khaledlarbi khaledlarbi commented Mar 20, 2025 •
edited
Loading

  • Change maintainer name and email (8514ef5)
  • Use Github Actions to check build on multiple platforms (macOS, Ubuntu, Windows ..)
  • Update cran-comments.md
  • Bump version from 0.3.2 to 0.3.3

haroine
haroine reviewed Sep 5, 2025
View reviewed changes
tests/testthat/test_calibration_small_dataset.R

test_that("Calibration on minimum bounds checks out", {

skip_if_not_installed("Rglpk")
Copy link
Collaborator

@haroine haroine Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a warning to make sure test don't pass silently without being executed anywhere

haroine
haroine approved these changes Sep 5, 2025
View reviewed changes
Copy link
Collaborator

@haroine haroine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khaledlarbi khaledlarbi merged commit bc46716 into master Sep 5, 2025
5 checks passed
@khaledlarbi khaledlarbi deleted the InseeFr_transfer branch September 5, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haroine haroine haroine approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@khaledlarbi @haroine