Skip to content

Fix german translations #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

niwla23
Copy link

@niwla23 niwla23 commented Jan 24, 2025

I have fixed some of the errors in the German translations. I did not fix everything but the most important things for a smooth checkout flow, including:

  • incorrect translation of "share"
  • incorrect translation of "complete payment"
  • broken countdown because of template getting broken in auto-translate.
  • various unnatural translations

As I am writing this, I just saw there is another pull request but it seems to fix other mistakes.

I am also not sure if the app should use formal (Sie) or informal (Du) language. Right now it is inconsistent.

Checklist

  • I have read the contributing guidelines.
  • My code is of good quality and follows the coding standards of the project.
  • I have tested my changes, and they work as expected.

I did not test the code, just edited the translations online

Copy link
Contributor

github-actions bot commented Jan 24, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@niwla23
Copy link
Author

niwla23 commented Jan 24, 2025

I have read the CLA Document and I hereby sign the CLA

@niwla23
Copy link
Author

niwla23 commented Jan 24, 2025

recheck

@niwla23
Copy link
Author

niwla23 commented Jan 24, 2025

update on formality: In my opinion, it would be best to have a per-event toggle for this in the long run. The preferred way of addressing the audience would vary heavily depending on the type of an event.

@leonv5
Copy link
Contributor

leonv5 commented Jan 25, 2025

it would be best to have a per-event toggle for this in the long run.

This would be the best way! I was the one, who did the other german translation fix and I had problems to decide what would be the appropriate approach. The easiest way for this formal/informal language toggle could be done simply with two versions of the translation.

@daveearley
Copy link
Contributor

Thank you very much for this!

@henrydatei
Copy link

Would be great if you can merge this change in

@HiEventsDev HiEventsDev deleted a comment from sonarqubecloud bot Feb 21, 2025
@daveearley
Copy link
Contributor

Thanks for this, and sorry for the delay. I've incorporated the changes into this PR

@daveearley daveearley closed this Jun 14, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants