-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(vertex-handler): remove p2p_manager dependency [part 1/8] #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10cad94
to
4da7ddb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1154 +/- ##
==========================================
- Coverage 84.66% 84.59% -0.07%
==========================================
Files 313 313
Lines 24245 24249 +4
Branches 3687 3690 +3
==========================================
- Hits 20527 20514 -13
- Misses 3004 3016 +12
- Partials 714 719 +5 ☔ View full report in Codecov by Sentry. |
bb13031
to
3c767f7
Compare
1 task
b6430fe
to
409f3f3
Compare
3c767f7
to
dc2977f
Compare
8e980c1
to
7dd0b6d
Compare
dc2977f
to
9d98daf
Compare
36692d0
to
b35cea4
Compare
|
Branch | refactor/vertex-handler/remove-p2p-manager |
Testbed | ubuntu-22.04 |
Click to view all benchmark results
Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Lower Boundary nanoseconds (ns) (Limit %) | Upper Boundary nanoseconds (ns) (Limit %) |
---|---|---|---|---|
sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 101,502,751,945.94 (-0.32%) | 91,650,003,337.89 (90.29%) | 112,016,670,746.31 (90.61%) |
b35cea4
to
14e43d1
Compare
1 task
msbrogli
approved these changes
Oct 23, 2024
jansegre
approved these changes
Oct 23, 2024
msbrogli
approved these changes
Oct 24, 2024
14e43d1
to
3203fbc
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1153
Motivation
As part of the P2P Multiprocess project, this PR refactors the
VertexHandler
so it does not depend on thep2p_manager
anymore.Acceptance Criteria
p2p_manager
dependency fromVertexHandler
. This means it does not propagate vertices anymore, and it's the caller's responsibility to do it.partial_vertex_exists
methods from sync classes and move it to the storage.VertexHandler.on_new_vertex
to propagate vertices accordingly:propagate_to_peers=False
, no change was necessary.propagate_to_peers
argument or set it asTrue
, add a follow-up call top2p_manager.send_tx_to_peers
.HathorManager.on_new_tx
toVertexHandler.on_new_vertex
.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged