-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(p2p): implement P2PDependencies class [part 6/11] #1152
Open
glevco
wants to merge
5
commits into
refactor/p2p/pre-ipc-refactors
Choose a base branch
from
refactor/p2p/dependencies
base: refactor/p2p/pre-ipc-refactors
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e5cdc20
to
c57665b
Compare
055ee2b
to
02f4846
Compare
c57665b
to
3967a8f
Compare
02f4846
to
717cff3
Compare
3967a8f
to
48a4de4
Compare
841444b
to
510a1f3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## refactor/p2p/pre-ipc-refactors #1152 +/- ##
==================================================================
+ Coverage 84.82% 84.85% +0.03%
==================================================================
Files 317 320 +3
Lines 24444 24462 +18
Branches 3698 3709 +11
==================================================================
+ Hits 20734 20757 +23
+ Misses 3003 2990 -13
- Partials 707 715 +8 ☔ View full report in Codecov by Sentry. |
510a1f3
to
72b2f79
Compare
72b2f79
to
0518c0a
Compare
10cad94
to
4da7ddb
Compare
50b73f2
to
a6a9480
Compare
4da7ddb
to
bb13031
Compare
375eee0
to
77d2710
Compare
bb13031
to
3c767f7
Compare
6b742bc
to
e5478b7
Compare
69d0842
to
a36b0c6
Compare
6e13bb7
to
0b86412
Compare
a36b0c6
to
5234061
Compare
0b86412
to
81565b1
Compare
81565b1
to
e7a4cf1
Compare
afffb92
to
e0fb633
Compare
dfa95ea
to
bcab3c6
Compare
bcab3c6
to
b8a851b
Compare
e0fb633
to
d12e8b0
Compare
d12e8b0
to
8e22ef6
Compare
901e292
to
3b27e43
Compare
8e22ef6
to
56993b9
Compare
3b27e43
to
97652fe
Compare
56993b9
to
1fff2ad
Compare
97652fe
to
5f45ef6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1165
Motivation
The goal of this PR is to isolate the sync so all its dependencies to the rest of the full node are in a single class,
P2PDependencies
. This means that every method that the sync called in the storage, in indexes, in the vertex handler, etc, are moved to this new class.Then, this class will serve as a proxy between the sync and the node. When the sync is moved to a subprocess, this class will serve as an interface to perform IPC or any other form of communication, and everything will be transparent to existing sync classes.
Acceptance Criteria
P2PDependencies
class and respective protocols to abstract each dependency.P2PDependencies
instance instead of individual dependencies.capabilities
fromHathorManager
toP2PDependencies
.whitelist_only
fromConnnectionsManager
toP2PDependencies
.tx_storage
in vertices anymore.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged