Skip to content

Throw a human-readable error when accessing a non-existent property of exposed object #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dinoel wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Throw a human-readable error when accessing a non-existent property of exposed object #686

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/comlink.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,9 +317,18 @@ export function expose(
};
const argumentList = (ev.data.argumentList || []).map(fromWireValue);
let returnValue;

const getDeepValue = (obj: any, path: string[]) =>
path.reduce((current, key) => {
if (current == null || !(key in current)) {
throw new Error(`Invalid path access: property '${key}' is undefined in path '${path.join(".")}'`);
}
return current[key];
}, obj);

try {
const parent = path.slice(0, -1).reduce((obj, prop) => obj[prop], obj);
const rawValue = path.reduce((obj, prop) => obj[prop], obj);
const parent = getDeepValue(obj, path.slice(0, -1));
const rawValue = getDeepValue(obj, path);
switch (type) {
case MessageType.GET:
{
Expand Down