Throw a human-readable error when accessing a non-existent property of exposed object#686
Open
dinoel wants to merge 1 commit intoGoogleChromeLabs:mainfrom
Open
Throw a human-readable error when accessing a non-existent property of exposed object#686dinoel wants to merge 1 commit intoGoogleChromeLabs:mainfrom
dinoel wants to merge 1 commit intoGoogleChromeLabs:mainfrom
Conversation
…f an exposed object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During development, we encountered an issue where calling an undefined function on a proxy object from a web worker resulted in a generic error such as "cannot call apply on undefined". This made development and debugging more difficult.
This small change validates that the property exists before accessing it and throws a human-readable error when it doesn’t.